Bug 1079732 (perl-Catalyst-Plugin-CustomErrorMessage)
| Summary: | Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sven Nierlein <Sven.Nierlein> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ddick, package-review, rc040203 |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.06-3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-05 19:02:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1069988 | ||
|
Description
Sven Nierlein
2014-03-23 14:53:26 UTC
Updated spec file according to comments from the related bugs and uploaded new files here: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessage.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessage-0.06-1.fc21.noarch.rpm Source RPM: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessage-0.06-1.fc21.src.rpm new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-CustomErrorMessage.spec the only thing i changed is the release number. Missing [MUSTFIX]: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Taking this one Hi Sven, The following patch file (and comments) shows work to do on this spec file --- perl-Catalyst-Plugin-CustomErrorMessage.old 2014-04-21 23:42:28.000000000 +1000 +++ perl-Catalyst-Plugin-CustomErrorMessage.proposed 2014-05-20 21:40:53.844909346 +1000 @@ -8,6 +8,8 @@ Source0: http://search.cpan.org/CPAN/authors/id/J/JK/JKUTEJ/Catalyst-Plugin-CustomErrorMessage-%{version}.tar.gz BuildArch: noarch BuildRequires: perl +BuildRequires: perl(base) +BuildRequires: perl(English) BuildRequires: perl(Test::More) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Carp::Clan) @@ -15,7 +17,14 @@ BuildRequires: perl(Class::Data::Inheritable) BuildRequires: perl(HTML::Entities) BuildRequires: perl(MRO::Compat) +BuildRequires: perl(Pod::Coverage) +BuildRequires: perl(strict) +BuildRequires: perl(Test::Distribution) +BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(URI::Escape) +BuildRequires: perl(warnings) +Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description Catalyst::Plugin::CustomErrorMessage is a Catalyst Plugin that provides @@ -39,8 +48,7 @@ %files %{perl_vendorlib}/* %{_mandir}/man3/* -%doc Changes -%doc README +%doc Changes README %changelog * Sun Apr 06 2014 Sven Nierlein <sven.nierlein> 0.06-2 Justifications follow MUST FIX; perl(base) is required at line 36 of lib/Catalyst/Plugin/CustomErrorMessage.pm perl(English) is required at line 9 of t/01-Catalyst-Plugin-CustomErrorMessage.t perl(Pod::Coverage) is required in t/pod-coverage.t perl(strict) is required at line 42 of lib/Catalyst/Plugin/CustomErrorMessage.pm perl(Test::Distribution) is required at line 3 of t/00-distribution.t perl(Test::Pod) is required at line 9 of t/pod.t perl(Test::Pod::Coverage) is required at line 7 of t/pod-coverage.t perl(warnings) is required at line 43 of lib/Catalyst/Plugin/CustomErrorMessage.pm OPTIONAL; The multiple %doc lines can safely be rolled into one line. Thanks, i added your changes here: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-CustomErrorMessage.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-CustomErrorMessage-0.06-3.fc21.src.rpm Review results License ok. Build/Requires ok no rpmlint warnings/errors pure perl library successful koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6868337 Package APPROVED New Package SCM Request ======================= Package Name: perl-Catalyst-Plugin-CustomErrorMessage Short Description: Catalyst plugin to have more cute error message Owners: sni Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). Hi Sven, Just a ping for the git work on this package. build and upload done |