Bug 1079936

Summary: Guided Decision Table: missing input validation if a comma needs to be allowed
Product: [Retired] JBoss BRMS Platform 6 Reporter: Zuzana Krejčová <zkrejcov>
Component: Business CentralAssignee: manstis
Status: CLOSED EOL QA Contact: Lukáš Petrovický <lpetrovi>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0.0CC: etirelli, kverlaen, lpetrovi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-27 19:40:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zuzana Krejčová 2014-03-24 10:42:53 UTC
Description of problem:
In GDTs, if an input field requires the use of a comma, anything is allowed as input. Input is checked in other cases and invalid text is not allowed.

If the "is contained in the (comma separated) list" operator is used, all characters are allowed even for an Integer field (and other numerical types and boolean). 
The '(optional) value list' input field in new condition pop-ups misbehaves in the same way (and as a consequence, makes the default value and cell values invalid too).


Version-Release number of selected component (if applicable):
BPMS 6.0.1 CR1


Steps to Reproduce:
1. Create a POJO Fact with attr. fieldInt of type Integer.
2. Create a new GDT.
3. Create a new Simple Condition column - use Fact as pattern, fieldInt as field, 'equal to' operator.
4. In the same new column pop-up, type 'a,b,c' into the '(optional) value list' input field.
5. Undo the last step, choose 'is contained in the (comma separated) list' operator and use 'a,b,c' as the default value.
6. Remove the default value and click 'Apply changes'.
7. Add a row and edit the cell for the new column - use 'a,b,c' again.


Actual results:
In steps 4, 5, 7, the invalid input is allowed.


Expected results:
In steps 4, 5, 7, the invalid input is not allowed, The invalid characters cannot be typed into the input field.

Comment 1 manstis 2014-03-24 11:42:06 UTC
This is by design at the moment. If a field's operator is "contained in the comma separated list" or "not contained in a comma separated list" we fall back to providing the user with a simple TextBox (unless the field has an enumeration defined for it). 

I've referenced the related community JIRA and changed this BZ to Enhancement (as it's not a bug).

Comment 2 Edson Tirelli 2014-03-24 17:02:09 UTC
As Michael mentioned, this is working as designed. If a change is required, then it has to be done as part of a feature release (6.1.0).

Comment 3 Zuzana Krejčová 2015-12-09 10:55:29 UTC
Still valid for 6.2.