Bug 1080002

Summary:	OVIRT35 - [RFE] Enable user defined Windows Sysprep file
Product:	[Retired] oVirt	Reporter:	Shahar Havivi <shavivi>
Component:	ovirt-engine-core	Assignee:	Shahar Havivi <shavivi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Novotny <pnovotny>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.5	CC:	adevolder, gklein, iheim, mavital, michal.skrivanek, obasan, rbalakri, s.kieske, yeylon
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:	ovirt-engine-3.5.0_beta	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-17 12:41:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1073961

Description Shahar Havivi 2014-03-24 13:45:12 UTC

oVirt use pre-defined Sysprep for each Windows OS.
By using the new Vm-Init feature we can use it to store VM/Template specific Sysprep file.

Comment 1 Michal Skrivanek 2014-03-25 09:13:42 UTC

please make sure it is exposed in REST API as well

Comment 2 Shahar Havivi 2014-03-25 09:20:27 UTC

(In reply to Michal Skrivanek from comment #1)
> please make sure it is exposed in REST API as well
its is and its automatic since its in custom_script, but now that I think of it I think I need to map it for a new <Sysprep> entry... (so it will match the UI behavior)

Comment 3 Michal Skrivanek 2014-05-13 10:26:59 UTC

*** Bug 1073961 has been marked as a duplicate of this bug. ***

Comment 4 Pavel Novotny 2014-06-13 12:24:43 UTC

FailedQA in ovirt-engine-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch (alpha2).

Content of the Sysprep editor in VM dialog / Initial Run is not saved after the dialog is submited.

Verification steps:
1. Create/edit a Windows VM and put some text in the Initial Run / Sysprep editor. 
2. Save the changes.
3. Edit the VM again and check the content in Sysprep editor.

Actual results:
The Sysprep editor is empty.

Expected results:
The sysprep content should be saved.

Additional info:
Also API confirms the custom Sysprep script wasn't saved, the <custom_script/> is empty, e.g., <vm><initialization><custom_script/>...

Comment 5 Pavel Novotny 2014-08-29 16:44:46 UTC

Verified in ovirt-engine-3.5.0-0.0.master.20140821064931.gitb794d66.el6.noarch (rc1.1).

If provided, custom sysprep file is processed and passed to the guest in A:\unattend.inf file instead of the oVirt default one, located in /usr/share/ovirt-engine/conf/sysprep/.
All $variables$ are replaced too, if present.

Note: Correctness of the sysprep file format is up to the user, oVirt doesn't verify the content, like XML validity or so.

Comment 6 Sandro Bonazzola 2014-10-17 12:41:00 UTC

oVirt 3.5 has been released and should include the fix for this issue.