Bug 1080158

Summary:	Do not use empty string as values for properties in rhq-storage.properties
Product:	[JBoss] JBoss Operations Network	Reporter:	John Sanda <jsanda>
Component:	Installer, Storage Node	Assignee:	Michael Burman <miburman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Filip Brychta <fbrychta>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	JON 3.2	CC:	bkramer, fbrychta, hrupp, loleary, miburman
Target Milestone:	DR01
Target Release:	JON 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	If the rhq.storage.hostname or rhq.storage.seeds properties were uncommented and left unset in rhq-storage.properties, the storage installer created an invalid configuration. The listen_address and seeds properties in cassandra.yaml were left blank, which caused the storage node startup to fail. The fix ignores empty values in rhq-storage.properties which ensures that invalid configuration is not introduced into cassandra.yaml, and fixes the originally-reported issue.	Story Points:	---
Clone Of:	1080157	Environment:
Last Closed:	2014-12-11 14:04:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1080157
Bug Blocks:

Description John Sanda 2014-03-24 19:12:00 UTC

+++ This bug was initially created as a clone of Bug #1080157 +++

Description of problem:
If the rhq.storage.hostname or rhq.storage.seeds properties are uncommented and left uninitialized with empty strings, the storage installer creates an invalid configuration. The listen_address and seeds properties in cassandra.yaml are left blank. The empty seeds property will cause the storage node startup to fail. The installer needs to fall back to default values if an empty string is used. This applies to all properties in rhq-storage.properties.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Michael Burman 2014-07-13 20:19:21 UTC

Fixed in master:

commit e4fd26bf70c3fe9be9b6efc79855e140850b20b5
Author: Michael Burman <miburman>
Date:   Sun Jul 13 23:15:03 2014 +0300

    [BZ 1080157] Ignore empty values in rhq-storage.properties

Comment 3 Simeon Pinder 2014-07-31 15:51:44 UTC

Moving to ON_QA as available to test with brew build of DR01: https://brewweb.devel.redhat.com//buildinfo?buildID=373993

Comment 4 Filip Brychta 2014-08-07 13:27:45 UTC

Verified on
Version :	
3.3.0.DR01
Build Number :	
6468454:dda0a47