Bug 1080436

*** Bug 1080393 has been marked as a duplicate of this bug. ***

Hello, Laszlo 

Besides the bug verification and general auto test acceptance test, do you think we need to run some additional function test (eg, cpu hotplug)? Or bug verification and acceptance are enough? 

Thanks,
Qunfang

Verified this bug on qemu-kvm-0.12.1.2-2.415.el6_5.7.x86_64.

Host version:
kernel-2.6.32-431.11.2.el6.x86_64
qemu-kvm-0.12.1.2-2.415.el6_5.7.x86_64
seabios-0.6.1.2-28.el6.x86_64

Guest:
kernel-2.6.32-431.el6.x86_64

Steps:
1. Boot up a guest with virt-manager with CPU maximum allocation 4 and current allocation is 2. 

[root@dell-per415-03 ~]# ps ax | grep kvm
 1151 ?        S      0:00 [kvm-irqfd-clean]
22447 ?        Sl     0:31 /usr/libexec/qemu-kvm -name rhel6 -S -M rhel6.5.0 -enable-kvm -m 2048 -realtime mlock=off -smp 2,maxcpus=4,sockets=4,cores=1,threads=1 -uuid 8299278b-f924-8c5b-0a2b-255abbdd356b -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/rhel6.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive file=/var/lib/libvirt/images/RHEL-Server-6.5-64-virtio.qcow2,if=none,id=drive-virtio-disk0,format=qcow2,cache=none -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x5,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -netdev tap,fd=25,id=hostnet0,vhost=on,vhostfd=26 -device virtio-net-pci,__com_redhat_macvtap_compat=on,netdev=hostnet0,id=net0,mac=52:54:00:0b:94:a6,bus=pci.0,addr=0x3 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -device usb-tablet,id=input0 -vnc 127.0.0.1:0 -vga cirrus -device intel-hda,id=sound0,bus=pci.0,addr=0x4 -device hda-duplex,id=sound0-codec0,bus=sound0.0,cad=0 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x6

2. virsh # list  
 Id    Name                           State
----------------------------------------------------
 4     rhel6                          running

virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":22453},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":22454}],"id":"libvirt-8"}


3. Plug another cpu and check it.

virsh # setvcpus --live rhel6 3

virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":22453},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":22454},{"enabled-in-acpi":true,"current":false,"CPU":2,"pc":-2130449717,"halted":true,"thread_id":22568}],"id":"libvirt-12"}

Now, all the 3 vcpus "enabled-in-acpi" field is "true".

4. Plug the 4th vcpu and check it again.

virsh # setvcpus --live rhel6 4

virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":22453},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":22454},{"enabled-in-acpi":true,"current":false,"CPU":2,"pc":-2130449717,"halted":true,"thread_id":22568},{"enabled-in-acpi":true,"current":false,"CPU":3,"pc":-2130449717,"halted":true,"thread_id":22570}],"id":"libvirt-16"}

Now, all the 3 vcpus "enabled-in-acpi" field is "true".

5.  Hot unplug 2 vcpu and check it.

virsh # setvcpus --live rhel6 2
error: Operation not supported: qemu didn't unplug the vCPUs properly

virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":22453},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":22454},{"enabled-in-acpi":false,"current":false,"CPU":2,"pc":-2130505407,"halted":true,"thread_id":22568},{"enabled-in-acpi":false,"current":false,"CPU":3,"pc":-2130505407,"halted":true,"thread_id":22570}],"id":"libvirt-22"}

Now, the cpu 2 and cpu 3 "enabled-in-acpi" field is "false".

Based on above, this issue should be fixed. I'm waiting for Laszlo's double confirm in bug 1081462 for safe.

(In reply to Qunfang Zhang from comment #9)

> Besides the bug verification and general auto test acceptance test, do you
> think we need to run some additional function test (eg, cpu hotplug)? Or bug
> verification and acceptance are enough? 

The libvirt fix and the qemu-kvm fix go together. Customers care about vcpu hot(un)plug as an "undivided" functionality. So it does make sense to upgrade both libvirt and qemu-kvm, and do end-to-end testing.

I didn't include / require success on the virsh level in the original testing steps because I wasn't sure about the scheduling of the libvirt bugfix. The qemu-kvm fix can be verified on the QMP level in isolation.

But, again, once you have both the libvirt and qemu-kvm fix in place, it's best to test end-to-end, which gives you verification for both the libvirt BZ and the qemu-kvm BZ.

Also, I answered your needinfo in bug 1081462.

Thanks
Laszlo

            libvirt      qemu-kvm     qemu-kvm-rhev
RHEL-6.6    bug 1066473         bug 1017858
RHEL-6.5.z  bug 1080439  bug 1080436  bug 1081462

(In reply to Laszlo Ersek from comment #11)
> (In reply to Qunfang Zhang from comment #9)
> 
> > Besides the bug verification and general auto test acceptance test, do you
> > think we need to run some additional function test (eg, cpu hotplug)? Or bug
> > verification and acceptance are enough? 
> 
> The libvirt fix and the qemu-kvm fix go together. Customers care about vcpu
> hot(un)plug as an "undivided" functionality. So it does make sense to
> upgrade both libvirt and qemu-kvm, and do end-to-end testing.
> 
> I didn't include / require success on the virsh level in the original
> testing steps because I wasn't sure about the scheduling of the libvirt
> bugfix. The qemu-kvm fix can be verified on the QMP level in isolation.
> 
> But, again, once you have both the libvirt and qemu-kvm fix in place, it's
> best to test end-to-end, which gives you verification for both the libvirt
> BZ and the qemu-kvm BZ.
> 
> Also, I answered your needinfo in bug 1081462.
> 
> Thanks
> Laszlo

Thank you, Laszlo. I tested again with the latest rhel6.5-z libvirt-0.10.2-29.el6_5.7.x86_64 installed. Now when hot unplug vcpu, virsh does not report error any more.

Test steps:

Same as comment 10.

Host version:
kernel-2.6.32-431.7.1.el6.x86_64
qemu-kvm-0.12.1.2-2.415.el6_5.7.x86_64
libvirt-0.10.2-29.el6_5.7.x86_64

[root@localhost ~]# virsh list 
 Id    Name                           State
----------------------------------------------------
 1     rhel6                          running

[root@localhost ~]# 
[root@localhost ~]# virsh 
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":2499},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":2500}],"id":"libvirt-8"}

virsh # 
virsh # 
virsh #  setvcpus --live rhel6 3

virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":2499},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":2500},{"enabled-in-acpi":true,"current":false,"CPU":2,"pc":-2130449717,"halted":true,"thread_id":3205}],"id":"libvirt-12"}

virsh # 
virsh # 
virsh # setvcpus --live rhel6 4

virsh # 
virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":2499},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":2500},{"enabled-in-acpi":true,"current":false,"CPU":2,"pc":-2130449717,"halted":true,"thread_id":3205},{"enabled-in-acpi":true,"current":false,"CPU":3,"pc":-2130449717,"halted":true,"thread_id":3348}],"id":"libvirt-16"}

virsh # 
virsh # 
virsh # setvcpus --live rhel6 2

virsh # 
virsh # 
virsh # qemu-monitor-command rhel6 '{ "execute" : "query-cpus" }'
{"return":[{"enabled-in-acpi":true,"current":true,"CPU":0,"pc":-2130449717,"halted":true,"thread_id":2499},{"enabled-in-acpi":true,"current":false,"CPU":1,"pc":-2130449717,"halted":true,"thread_id":2500},{"enabled-in-acpi":false,"current":false,"CPU":2,"pc":-2130505407,"halted":true,"thread_id":3205},{"enabled-in-acpi":false,"current":false,"CPU":3,"pc":-2130505407,"halted":true,"thread_id":3348}],"id":"libvirt-22"}

virsh #

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0360.html