Bug 1080472

Summary: The unit in the new d3 charts is not refreshed correctly
Product: [Other] RHQ Project Reporter: bkramer <bkramer>
Component: Core UIAssignee: Mike Thompson <mithomps>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: urgent    
Version: 4.9CC: ahovsepy, hrupp, skondkar, tobias
Target Milestone: ---   
Target Release: RHQ 4.11   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-21 10:14:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1080470    
Attachments:
Description Flags
Incorrect unit screen shots
none
metric_unit2
none
metric_units3
none
YAxis Scale issue none

Description bkramer 2014-03-25 13:55:41 UTC
Created attachment 878467 [details]
Incorrect unit screen shots

Description of problem:
Sometimes, the unit is not properly refresh and it will show GB although it should be MB - see attached screen shots for more information.

Version-Release number of selected component (if applicable):
RHQ 4.9

How reproducible:
Sometimes

Steps to Reproduce:
1. Install RHQ 4.9
2. Navigate to Inventory -> Platforms and select server platform
3. Navigate to Monitoring -> Metrics and check unit on the charts for metrics like Actual Free Memory, Actual Used Memory,... 

Actual results:
The unit is incorrectly showing GB although the numbers are clearly showing MB values.

Expected results:
The correct unit is shown.

Additional info:
The same graph rendered for a different time period will show a proper unit.

Comment 1 Mike Thompson 2014-04-08 15:55:36 UTC
The bug is an erratic one but one that is reproduced by finding a time range for a graph that has different Scales between the min and max (example: MB and GB). The Y-Axis was using the min scale which caused was not consistent with the avg or high values.

I reproduced this by using the above steps, but used 'Free Memory' and found a date range of 5D for my metrics that produced a different scale for min vs max values.


The fix involved changing scale conversion routine to map to the same scale for all of the numbers. Eliminating the possibility of differing scales being showing up on the same graph.



Commit 72f91658c25fbff3d5c229372129c2178f435b33
Author: Mike Thompson <mithomps>
Date:   Mon Apr 7 17:54:26 2014 -0700

    BZ 1080472 - The unit in the new d3 charts is not refreshed correctly.
    Fix the bug that improperly calculates the units of measure on the Y-Axis and on Min Value of chart legend.

Comment 2 Armine Hovsepyan 2014-04-09 09:52:33 UTC
Created attachment 884455 [details]
metric_unit2

visible in RHQ Mater , buildid: 2568952

Comment 3 Armine Hovsepyan 2014-04-09 09:53:47 UTC
Created attachment 884456 [details]
metric_units3

MIN, MAX, AVG metrics have different Units which (i guess) leads to having the issue

Comment 4 Mike Thompson 2014-04-09 13:57:53 UTC
Created attachment 884507 [details]
YAxis Scale issue

Comment 5 Mike Thompson 2014-04-09 14:00:16 UTC
I think we just have a misunderstanding on what we were testing. The issue was with the scale (units) being wrong in the graph. The scale in the legend can be different units but that is now not corrupting the scale of the metrics plotted. See latest attachment for further illustration: 884507.

I think we are good please retest.

Comment 6 Armine Hovsepyan 2014-04-09 14:03:43 UTC
thanks for the clarification Mike. Not able to reproduce on master. marking as verified.

Comment 7 Heiko W. Rupp 2014-07-21 10:14:10 UTC
Bulk closing of RHQ 4.11 issues, now that RHQ 4.12 is out.

If you find an issue with those, please open a new BZ, linking to the old one.