Bug 108049
| Summary: | %makeinstall should use %__make for make | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Raw Hide | Reporter: | Jens Petersen <petersen> | ||||
| Component: | redhat-rpm-config | Assignee: | Elliot Lee <sopwith> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.0 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2003-11-03 20:35:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 95501 [details]
trivial patch to use __make instead
Consistent, yes. Worth the effort? Hardly. It is a trivial patch, where is the effort? I need this for building emacs on i386 currently... Yes, it's a trivial patch, but a huge QA effort to verify nothing broke by rebuilding everything. There's nothing forcing you to use %makeinstall, nor is there any reason that you cannot attempt redefinition in your xemacs spec file. Nor is there anything stopping you from changing %makeinstall in redhat-rpm-config Fair'nuf, shooting for redhat-rpm-config instead then. Elliot, if you're ok with this (for the next release), can I go ahead and make this change, or do you want to do it? This is fixed in The comments about needing this for emacs worry me though. It shouldn't be necessary to redefine __make except in very strange circumstances. Because I need "__make" to be "setarch i386" to build emacs on ix86 currently... (bug 101818). "setarch i386 make" that is. |
Description of problem: I think it would be more consistent if %makeinstall was defined to use %{__make} instead of make. Could this please be done?