Bug 1080949
Summary: | wrong date header with locale in alert mails | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Harald Reindl <h.reindl> |
Component: | smokeping | Assignee: | Terje Røsten <terje.rosten> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 20 | CC: | cra, terje.rosten |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | smokeping-2.6.9-3.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-04-05 04:51:28 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Harald Reindl
2014-03-26 10:49:35 UTC
Thanks for your report. what may help without touch the code is explicit set the locale to POSIX in the systemd-unit, i will know in a short because currently one of our internet connections has packet loss [Service] Environment="LANG=C" smokeping-2.6.9-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/smokeping-2.6.9-3.fc19 smokeping-2.6.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/smokeping-2.6.9-3.fc20 impressive reaction, i would sell my soul for mor maintainers not feeling abused by reports! i am about deploy the update with Environment="LANG=C" anyways since we are use some systemd features to restrict the daemon permissions which works not perfect in case of new targets but is do-able [Unit] Description=Smokeping After=network.service systemd-networkd.service openvpn.service [Service] Type=simple PermissionsStartOnly=true Environment="LANG=C" ExecStartPre=/usr/bin/chown -R nobody:apache /var/lib/smokeping/ ExecStart=/usr/sbin/smokeping --nodaemon ExecReload=/usr/bin/kill -HUP $MAINPID StandardError=syslog Restart=always RestartSec=1 Nice=19 IOSchedulingClass=3 PrivateTmp=true CapabilityBoundingSet=CAP_CHOWN CAP_SETGID CAP_SETUID CAP_DAC_OVERRIDE CAP_KILL CAP_NET_ADMIN CAP_NET_BROADCAST CAP_NET_RAW CAP_SYS_CHROOT ReadOnlyDirectories=/etc ReadOnlyDirectories=/usr InaccessibleDirectories=/boot InaccessibleDirectories=/home InaccessibleDirectories=/root InaccessibleDirectories=/usr/local/scripts InaccessibleDirectories=/var/lib/rpm InaccessibleDirectories=/var/lib/yum InaccessibleDirectories=/var/spool User=nobody Group=apache [Install] WantedBy=multi-user.target Thanks. Where is $MAINPID coming from, systemd? Are you using SELinux? Would be nice to fix this one: https://bugzilla.redhat.com/show_bug.cgi?id=868893 Seen something similar? $MAINPID is coming from systemd - Type=simple no idea in case of https://bugzilla.redhat.com/show_bug.cgi?id=868893 no SELinux here, the problem is normally smokeping is running as root what i have achieved here is running as user:nobody and group:apache _________________________________ this is a workaround and let the ExecStartPre run as root to fix permissions which works mostly but has some races in case of new targets like adde today, maybe a find-call for files/folders and set permissions would fix that fine in "ExecStartPre" but mostly only after minimum of one restart - i can live with that but not with have processes runnign as root all the time, however, not a big deal since it's working well enough and new targets no added every day - for inlcude it in the distribution that likely would need more cleanup PermissionsStartOnly=true ExecStartPre=/usr/bin/chown -R nobody:apache /var/lib/smokeping/ Yeah, I understand your concern regarding, hope to get time to switch to unpriv user at some point. Yeah, I understand your concern regarding root, hope to get time to switch to unpriv user at some point. no problem, AFAIR i noticed that in a bugreport some time ago but for people who really care it's do-able and it would cause more harm if try to achieve that as default would break new instalaltions of others, a nice long-term thing anyways however, the output below may sehd some light about $MAINPID in that case 27036 which is the perl process itself [root@thx1138:~]$ systemctl status smokeping.service smokeping.service - Smokeping Loaded: loaded (/etc/systemd/system/smokeping.service; enabled) Active: active (running) since Mi 2014-03-26 20:53:56 CET; 1h 0min ago Process: 27032 ExecStartPre=/usr/bin/chown -R nobody:apache /var/lib/smokeping/ (code=exited, status=0/SUCCESS) Main PID: 27036 (perl) CGroup: name=systemd:/system/smokeping.service ├─ 7180 /usr/sbin/fping -C 41 -q -B1 -r1 -i10 **stripped** ├─27036 perl /usr/sbin/smokeping --nodaemon ├─27066 /usr/sbin/smokeping [FPing └─27067 /usr/sbin/smokeping [DNS BTW: confirmed with smokeping-2.6.9-3.fc19.noarch, given that the changelog says there is no longer a date-header added by smokeping my assumption postfix adds it anyways was correct Subject: [SmokeAlert] packetloss_critical is active on DNS-Latency.ns1 Date: Thu, 27 Mar 2014 15:54:47 +0100 (CET) Package smokeping-2.6.9-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing smokeping-2.6.9-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-4431/smokeping-2.6.9-3.fc19 then log in and leave karma (feedback). smokeping-2.6.9-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. smokeping-2.6.9-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |