Bug 1081622

Summary: mash keeps silly amount of drpms for rawhide
Product: [Fedora] Fedora Reporter: Kevin Fenzi <kevin>
Component: mashAssignee: Dennis Gilmore <dennis>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dennis, rbean, robatino
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-23 03:32:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Minor optimization patch
none
Patch to only copy drpms if they are new-ish. none

Description Kevin Fenzi 2014-03-27 17:34:23 UTC 
mash seems to be keeping around lots of really old drpms. 

It seems to keep them for every package which has updated since the tag inheritence was set. There are currently: 

38421 

drpms in the x86_64 rawhide repo. 

Folks using rawhide update usually daily, and if not, at least very often. I cannot imagine someone updating from a year ago and expecting delta rpms to be around. 

Proposal: Only drpms newer than 7 days are kept. Users updating older rawhide installs will just use the entire rpms. This will save us tons of IO and compose time and disk space and in general be more friendly. 

Also see: bug 1039365 where mirrors are having trouble with the 38+k files in one dir.
Comment 1 Ralph Bean 2014-03-29 17:14:19 UTC 
Created attachment 880196 [details]
Minor optimization patch

This is non-essential, but I couldn't help myself.
Comment 2 Ralph Bean 2014-03-29 17:14:48 UTC 
Created attachment 880197 [details]
Patch to only copy drpms if they are new-ish.

This should do it.
Comment 3 Ralph Bean 2014-07-16 04:15:54 UTC 
This was merged here:  https://git.fedorahosted.org/cgit/mash/commit/?id=5dc7a5f7214bc57e3df21ec0822f7e603207d048
Comment 4 Kevin Fenzi 2014-07-16 14:48:31 UTC 
I'll note that this still isn't working right. ;( 

Somehow mash isn't doing the right thing. ;(
Comment 5 Ralph Bean 2014-07-16 17:06:00 UTC 
Ok.

Next step is probably to post some logs here of what it's doing incorrectly.
Comment 6 Kevin Fenzi 2014-07-16 22:46:35 UTC 
Sadly mash doesn't log much: 

http://koji.fedoraproject.org/mash/rawhide-20140716/logs/mash.log

We could perhaps try running it manually in stg?
Comment 7 Ralph Bean 2014-10-06 16:52:38 UTC 
Is it possible that the config variable max_delta_rpm_age was never set in /etc/bodhi/mash.conf ?

I can't find reference to that var anywhere in the puppet or ansible histories.
Comment 8 Kevin Fenzi 2014-10-06 17:38:01 UTC 
https://git.fedorahosted.org/cgit/mash/commit/?id=bcb1d00028695a4311ad83df8964411857a5b14b

It's changed in the mash package, because we compose in a chroot for rawhide/branched with the version of mash there. :)
Comment 9 Ralph Bean 2015-01-23 03:31:12 UTC 
Is this fixed now as of https://git.fedorahosted.org/cgit/mash/commit/?id=ed0f1374ac920b4def8899b530e94d5d9ece4232 ?
Comment 10 Kevin Fenzi 2015-01-23 03:32:40 UTC 
Yep!