Bug 1081939

Summary: Don't put '+' button in front of basic type fields in Add Fields By Origin
Product: [Retired] JBoss BPMS Platform 6 Reporter: Jan Hrcek <jhrcek>
Component: Form ModelerAssignee: Pere Fernàndez <pere.fernandez>
Status: CLOSED CURRENTRELEASE QA Contact: Pavel Kralik <pkralik>
Severity: low Docs Contact:
Priority: medium    
Version: 6.0.1CC: kverlaen, rrajasek
Target Milestone: ER2   
Target Release: 6.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 19:50:28 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Video showing the problem
none
Ideal solution proposal none

Description Jan Hrcek 2014-03-28 08:49:01 UTC
Created attachment 879760 [details]
Video showing the problem

Description of problem:
This is not a bug, but request for echancement. When you add Basic type (Bool, Integer, Date etc.) as Field Data origin, and then you go to Add fields by Origin, there is a '+' button rendered in front of each data origin, even though there is nothing to expand with this plus button.
This can be confusing to the users, because when they click the plus, the list moves a bit, but nothing else happens. It looks, that there is something broken, even though everything is ok.

Observe the problem in the video attached.


Version-Release number of selected component (if applicable):
BPMS 6.0.1 CR2

How reproducible:
Always

Steps to Reproduce:
1. In Form Data Origin add some origins 'From Basic Type'
2. Go to Add fields by origin

Actual results:
The + button rendered in front of each data origin does nothing, because there is nothing to expand (Basic types represent primitive values)

Expected results:
There should be no + button, just blank red branching, as is the case for fields of complex type (from Data model, from java class). See screenshot of how it should look in ideal case.

Comment 1 Jan Hrcek 2014-03-28 08:59:32 UTC
Created attachment 879761 [details]
Ideal solution proposal

Comment 2 Pere Fernàndez 2014-04-10 13:45:28 UTC
Showing the "Basic Type Sources" without the '+'. Also changed the way the source color is showing to make it clearer. 

Commit (master): https://github.com/droolsjbpm/jbpm-form-modeler/commit/04f527b47c24921a1c19f8e4207151bcd4f8bc2a

Commit (6.0.x): https://github.com/droolsjbpm/jbpm-form-modeler/commit/90551a23af67862feb772345bc73283052021fee

Comment 3 Pavel Kralik 2014-05-02 14:10:31 UTC
Verified bpms-6.0.2.ER2 w/ EAP6.X.