Bug 1081966

Summary:	Review Request: perl-MooseX-Types-Path-Tiny - Path::Tiny types and coercions for Moose
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	David Dick <ddick>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, package-review
Target Milestone:	---	Flags:	ddick: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-MooseX-Types-Path-Tiny-0.010-2.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-14 22:41:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Howarth 2014-03-28 10:52:04 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MooseX-Types-Path-Tiny/branches/fedora/perl-MooseX-Types-Path-Tiny.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-MooseX-Types-Path-Tiny/perl-MooseX-Types-Path-Tiny-0.010-1.fc21.src.rpm

Description:
This module provides Path::Tiny types for Moose. It handles two important
types of coercion:

 * Coercing objects with overloaded stringification

 * Coercing to absolute paths

It also can check to ensure that files or directories exist.

Fedora Account System Username: pghmcfc

Comment 1 David Dick 2014-03-28 23:31:59 UTC

Package built ok for rawhide only at http://koji.fedoraproject.org/koji/taskinfo?taskID=6685344

FIX 

BR: Moose::Conflicts (t/zzz-check-breaks.t line 9, currently packaged as part of perl-Moose)

TODO:

BR: ExtUtils::MakeMaker >= 6.30 (Makefile.PL line 10).  This is such an old version of ExtUtils::MakeMaker that it is irrelevant (possibly excluding EL5)

Comment 2 Paul Howarth 2014-03-29 14:24:12 UTC

(In reply to David Dick from comment #1)
> Package built ok for rawhide only at
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6685344
> 
> FIX 
> 
> BR: Moose::Conflicts (t/zzz-check-breaks.t line 9, currently packaged as
> part of perl-Moose)

Good catch; fixed in -2.

> TODO:
> 
> BR: ExtUtils::MakeMaker >= 6.30 (Makefile.PL line 10).  This is such an old
> version of ExtUtils::MakeMaker that it is irrelevant (possibly excluding EL5)

I don't think this is needed. ExtUtils::MakeMaker is used in two places:

1. In Makefile.PL, where version 6.30 is wanted. However, the package is built using Module::Build::Tiny and doesn't actually use Makefile.PL, so this one doesn't matter.

2. In t/00-report-prereqs.t, where any version is OK. Hence I omitted the version requirement.

In practice, this version requirement really doesn't matter. Version 6.30 is available all the way back to EL-5, whilst Path::Tiny (also required by the module) can only be built for F-19 onwards due to its requirement for File::Spec ≥ 3.40, so the version of ExtUtils::MakeMaker will always be OK.

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MooseX-Types-Path-Tiny/branches/fedora/perl-MooseX-Types-Path-Tiny.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-MooseX-Types-Path-Tiny/perl-MooseX-Types-Path-Tiny-0.010-2.fc21.src.rpm

Comment 3 David Dick 2014-03-29 20:30:33 UTC

Agreed.

APPROVED

Comment 4 Paul Howarth 2014-03-29 20:44:33 UTC

New Package SCM Request
=======================
Package Name: perl-MooseX-Types-Path-Tiny
Short Description: Path::Tiny types and coercions for Moose
Owners: pghmcfc
Branches: f20 epel7
InitialCC: perl-sig

Thanks for the review David.

Comment 5 Gwyn Ciesla 2014-03-31 11:50:09 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-03-31 13:27:41 UTC

perl-MooseX-Types-Path-Tiny-0.010-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-MooseX-Types-Path-Tiny-0.010-2.fc20

Comment 7 Fedora Update System 2014-04-02 09:06:54 UTC

perl-MooseX-Types-Path-Tiny-0.010-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 8 Fedora Update System 2014-04-14 22:41:03 UTC

perl-MooseX-Types-Path-Tiny-0.010-2.fc20 has been pushed to the Fedora 20 stable repository.