Bug 108213
| Summary: | LTC5169 - ethtool -S not working with the e1000 driver | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 3 | Reporter: | Olof Johansson <olof> | ||||||
| Component: | kernel | Assignee: | Julie DeWandel <jdewand> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Brian Brock <bbrock> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 3.0 | CC: | msw, petrides, riel | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | powerpc | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2004-01-19 19:04:35 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Olof Johansson
2003-10-28 17:12:17 UTC
I will attach a proposed patch to the RHEL 3 sources to correct this problem. If you guys (IBM) get a chance to test it, it would be appreciated. I have verified it here. Created attachment 95588 [details]
Patch for ethtool -S <netdev> against RHEL 3 released product.
The problem was only a problem for ethtool compiled as a 32-bit application.
Worked fine as a 64-bit app.
------- Additional Comments From olof.com 2003-30-10 21:21 ------- Rick, can you test the patch RH provided? They have modified the ioctl layers, so the BK patch doesn't apply to their tree. ------- Additional Comments From olof.com 2003-30-10 21:21 ------- Rick, can you test the patch RH provided? They have modified the ioctl layers, so the BK patch doesn't apply to their tree. ricardoz.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |FIXEDAWAITINGTEST
Resolution| |FIX_BY_DISTRO
------- Additional Comments From ricardoz.com 2003-31-10 13:07 -------
I just tested the patch and it works now. Defect has been fixed.
------- Additional Comments From ricardoz.com 2003-31-10 13:09 ------- When would we expect this patch to be in the RHEL3 distro. ? Thank you for testing this patch. A suggestion was made from a kernel team member for an improved version which I'd like to explore. My plan is to try the second version and post it to here if all goes well. Either way, I expect this issue to be resolved within the coming week. But to answer your question, this problem will be fixed in Update 1 for RHEL 3. Created attachment 95637 [details]
A second way to solve this problem
This patch creates a much simpler ethtool_ioctl interface for 32-bit apps. All
ioctl commands are supported this way (both now and with future drivers). This
code borrow heavily from the 2.5 code. A patch review by IBM would be
appreciated as would testing of this patch. It has been tested here and appears
to work, but futher verification is always nice.
------- Additional Comments From olof.com 2003-31-10 17:44 ------- Julie, appropriate review method would be to post on linuxppc64-dev. Thanks. The second patch was submitted on 05-OCT-03 and should appear in Update 1. Closing on our side after verifying with IBM. |