Bug 1082332
| Summary: | Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jamie Nguyen <jamielinux> |
| Component: | Package Review | Assignee: | T.C. Hollingsworth <tchollingsworth> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, tchollingsworth |
| Target Milestone: | --- | Flags: | tchollingsworth:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-31 19:33:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1082329, 1082330 | ||
| Bug Blocks: | 956806, 1082334 | ||
|
Description
Jamie Nguyen
2014-03-30 12:47:26 UTC
Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-tiny-lr-fork.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-tiny-lr-fork-0.0.5-2.fc21.src.rpm * Sun Mar 30 2014 Jamie Nguyen <jamielinux> - 0.0.5-2 - symlink to _bindir Looking at the names in %{_bindir} I'd guess this will conflict with the original tiny-lr. But that upstream seems really dead, so I'm happy to ship this.
I'd suggest contacting upstream and let them know they can steal the real tiny-lr name if that upstream is really dead, following the advice in 'npm help disputes':
https://www.npmjs.org/doc/misc/npm-disputes.html
The note about the tests kinda freaks me out a little, are we too old or they?
Nothing blocking here though, so APPROVED.
(In reply to T.C. Hollingsworth from comment #2) > Looking at the names in %{_bindir} I'd guess this will conflict with the > original tiny-lr. But that upstream seems really dead, so I'm happy to ship > this. > > I'd suggest contacting upstream and let them know they can steal the real > tiny-lr name if that upstream is really dead, following the advice in 'npm > help disputes': > https://www.npmjs.org/doc/misc/npm-disputes.html There is a comment here from tiny-lr-fork maintainer: https://github.com/gruntjs/grunt-contrib-watch/pull/296#issuecomment-36043332 > I appreciate the intent but I don't consider tiny-lr > "abandoned" unless @mklabs has stated he has abandoned > it. I believe he is just on hiatus and hopefully will > return (as he is a great developer I really appreciate > his work). > The note about the tests kinda freaks me out a little, are we too old or > they? They are too old. Our express and connect is right up to date! (Well, ok so in the time that it took me to post the updates and get them pushed to stable, there's been a new minor point release of both...) > Nothing blocking here though, so APPROVED. Thanks! New Package SCM Request ======================= Package Name: nodejs-tiny-lr-fork Short Description: A tiny LiveReload server implementation you can spawn in the background Owners: jamielinux patches Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). |