Bug 1082832
| Summary: | RFE: make whitelist and blacklist config options instead of hard coded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> | ||||||
| Component: | mash | Assignee: | Dennis Gilmore <dennis> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | dennis, lmacken, pbrobinson, rbean | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | mash-0.6.16-1.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-07-23 08:58:21 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 881932 [details]
Reorganize the multilib method init to accept the full config.
Created attachment 881933 [details]
Make blacklist/whitelist into config values.
These patches no longer apply cleanly. Rebased versions of them were sent to the rel-eng list: https://lists.fedoraproject.org/pipermail/rel-eng/2014-July/018149.html Rebased and sent to the list again. https://lists.fedoraproject.org/pipermail/rel-eng/2015-January/019256.html +1, the patch looks good to me. So this would allow for bodhi (eventually koji?) to pass in custom multilib black/whitelists, but where would it get the list from? Is this something that can be automatically generated or is it updated purely on a case-by-case basis? Filed a rel-eng meeting ticket to try and have this addressed: https://fedorahosted.org/rel-eng/ticket/6163 Pinged on the buildsys list: https://lists.fedoraproject.org/pipermail/buildsys/2015-April/004647.html (In reply to Ralph Bean from comment #4) > Rebased and sent to the list again. > https://lists.fedoraproject.org/pipermail/rel-eng/2015-January/019256.html They don't appear to be available against either of the above linked rel-eng lists, presumably they were attached vs inline and hence lost by the list tools. Any chance to get the latest attached here or sent inline to the list? updated patches applied upstream mash-0.6.14-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mash-0.6.14-1.fc22 mash-0.6.14-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mash-0.6.14-1.el7 mash-0.6.14-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mash-0.6.14-1.el6 Package mash-0.6.14-1.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing mash-0.6.14-1.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6084/mash-0.6.14-1.el7 then log in and leave karma (feedback). mash-0.6.16-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. mash-0.6.16-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. mash-0.6.16-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Right now mash has a blacklist and whitelists that are hard coded into the multilib.py file. There are different types of multilib that it has different lists for, so this may need to be multiple options. ... blacklist = [ 'tomcat-native' ] whitelist = [ 'libgnat', 'wine', 'lmms-vst', 'nspluginwrapper', 'libflashsupport', 'valgrind', 'perl-libs', 'redhat-lsb', 'yaboot' ] ... blacklist = ['dmraid-devel', 'kdeutils-devel', 'mkinitrd-devel', 'java-1.5.0-gcj-devel', 'java-1.7.0-icedtea-devel', 'php-devel', 'java-1.6.0-openjdk-devel', 'java-1.7.0-openjdk-devel', 'java-1.8.0-openjdk-devel' ] ... It would be nice to have this as config options so they could be adjusted without having to rebuild the package.