Bug 1083589

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[471,64] incompatible types: org.springframework.security.core.context.SecurityContext cannot be converted to org.acegisecurity.context.SecurityContext
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[797,19] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.ByteArrayOutputStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[815,23] cannot find symbol
  symbol:   method exec(java.lang.String,org.apache.commons.io.output.TeeOutputStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[850,19] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.PrintStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1039,27] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.PrintStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1043,31] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.PrintStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1049,23] cannot find symbol
  symbol:   method exec(java.lang.String,hudson.util.NullStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1062,19] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.PrintStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1070,19] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.ByteArrayOutputStream)
  location: variable connection of type com.trilead.ssh2.Connection
[ERROR] /builddir/build/BUILD/ssh-slaves-plugin-ssh-slaves-1.6/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java:[1165,39] cannot find symbol
  symbol:   method exec(java.lang.String,java.io.PrintStream)
  location: variable connection of type com.trilead.ssh2.Connection
[INFO] 10 errors

Hi gil,

Thanks for doing the review. The package builds fine in koji [1]. It needs latest versions of some of its dependencies which don't hit the mirrors yet. You can wait day or two, or you can download prebuilt RPMs from koji and run fedora-review with "-p". It's up to you.


[1]: http://koji.fedoraproject.org/koji/taskinfo?taskID=6700199

(In reply to Michal Srb from comment #2)
> Hi gil,
> 
> Thanks for doing the review. The package builds fine in koji [1]. It needs
> latest versions of some of its dependencies which don't hit the mirrors yet.
> You can wait day or two, or you can download prebuilt RPMs from koji and run
> fedora-review with "-p". It's up to you.
> 
> 
> [1]: http://koji.fedoraproject.org/koji/taskinfo?taskID=6700199

for me is all right! use prebuilt RPMs right now

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: jenkins-ssh-slaves-plugins.spec should be jenkins-ssh-slaves-
  plugin.spec
  See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
FIXME
- This seems like a Java package, please install fedora-review-plugin-java to
  get additional checks


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
     Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jenkins-
     ssh-slaves-plugin-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/gil/1083589-jenkins-ssh-slaves-plugin
     /review-jenkins-ssh-slaves-plugins/srpm-unpacked/jenkins-ssh-slaves-
     plugins.spec
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: jenkins-ssh-slaves-plugin-1.6-1.fc21.noarch.rpm
          jenkins-ssh-slaves-plugin-javadoc-1.6-1.fc21.noarch.rpm
          jenkins-ssh-slaves-plugin-1.6-1.fc21.src.rpm
jenkins-ssh-slaves-plugin.src: E: invalid-spec-name
3 packages and 0 specfiles checked; 1 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint jenkins-ssh-slaves-plugin-javadoc jenkins-ssh-slaves-plugin
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
jenkins-ssh-slaves-plugin-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

jenkins-ssh-slaves-plugin (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
jenkins-ssh-slaves-plugin-javadoc:
    jenkins-ssh-slaves-plugin-javadoc

jenkins-ssh-slaves-plugin:
    jenkins-ssh-slaves-plugin
    mvn(org.jenkins-ci.plugins:ssh-slaves)



Source checksums
----------------
https://github.com/jenkinsci/ssh-slaves-plugin/archive/ssh-slaves-1.6.tar.gz :
  CHECKSUM(SHA256) this package     : 197abc84d73cb4084400cb8bda007862f605d1cce85dd581c0723ed57a4e41ba
  CHECKSUM(SHA256) upstream package : 197abc84d73cb4084400cb8bda007862f605d1cce85dd581c0723ed57a4e41ba


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -vpn jenkins-ssh-slaves-plugin -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Please, fix spec file name before import

Fixed:

Spec URL: http://msrb.fedorapeople.org/review/2/jenkins-ssh-slaves-plugin.spec
SRPM URL: http://msrb.fedorapeople.org/review/2/jenkins-ssh-slaves-plugin-1.6-1.fc21.src.rpm

Thanks for the review.

New Package SCM Request
=======================
Package Name: jenkins-ssh-slaves-plugin
Short Description: Jenkins SSH Slaves Plugin
Owners: msrb sochotni mizdebsk msimacek
Branches: f20
InitialCC: java-sig

Git done (by process-git-requests).

In Rawhide, closing. Thanks for the review and the repo.