Bug 1084007
| Summary: | Review Request: google-roboto-fonts - Google Roboto fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Tardon <dtardon> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dtardon, fonts-bugs, i18n-bugs, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-07 12:58:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Tardon
2014-04-03 11:53:27 UTC
Issues: 1) It's better to use subpackage name -common and not -license. See http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts suggests using -common for common files needed by all other packages. 2) Requires: fontpackages-filesystem is missing for -condensed-fonts subpackage. The other simple way is to add it to -common and let -common be required by google-roboto-fonts and google-roboto-condensed-fonts. This way -common will provide LICENSE.txt file and you can also add RobotoSpecimenBook.pdf as a %doc If you add -common then let it alone Requires: fontpackages-filesystem 3) Group tag is no longer needed. 4) Summary can be "Google Roboto fonts" Spec URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts.spec SRPM URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts-1.2-2.fc20.src.rpm Review: + Package built fine in mock on rawhide + rpmlint on generated rpms gave google-roboto-condensed-fonts.noarch: W: no-documentation google-roboto-fonts.noarch: W: no-documentation google-roboto-fonts.src: W: invalid-url Source0: http://developer.android.com/downloads/design/roboto-1.2.zip HTTP Error 405: Method Not Allowed 4 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) source tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5 srpm tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5 + fontconfig rules provided and follow fonts packaging guidelines. APPROVED. New Package SCM Request ======================= Package Name: google-roboto-fonts Short Description: Google Roboto fonts Owners: dtardon Branches: f19 f20 InitialCC: I request please re-submit above request with addition as IntialCC: fonts-sig i18n-team New Package SCM Request ======================= Package Name: google-roboto-fonts Short Description: Google Roboto fonts Owners: dtardon Branches: f19 f20 InitialCC: fonts-sig i18n-team Git done (by process-git-requests). google-roboto-fonts-2.138-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-30d4a534b6 google-roboto-fonts-2.138-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |