Bug 1084190

Koji Task build 
http://koji.fedoraproject.org/koji/taskinfo?taskID=6707625

Rpmlint output

SPECS/hamekoz-tiempos.spec: W: invalid-url Source0: http://github.com/Hamekoz/hamekoz-tiempos/releases/download/v0.1.0/hamekoz-tiempos-0.1.0.tar.gz HTTP Error 403: Forbidden
hamekoz-tiempos.src: W: invalid-url Source0: http://github.com/Hamekoz/hamekoz-tiempos/releases/download/v0.1.0/hamekoz-tiempos-0.1.0.tar.gz HTTP Error 403: Forbidden
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

I don't know why, if browse url the file is download.

* you do not need requires filed at your spec file. rpm can find them, unless you need exactly special version.
* use make_install macro instead of make install DESTDIR=%{build root}
* probably you need to put your mono exe at libexec not libdir
* add license file into your tar ball and spec at %doc 
* you should add license header inside top of your source files.

additionally for github
you may use : https://fedoraproject.org/wiki/Packaging:SourceURL#Github

however spectool can download source.

Yep, that's

  https://fedoraproject.org/wiki/Packaging:Guidelines#Requires_2

for the automatic dependencies. And

  https://fedoraproject.org/wiki/Packaging:Mono

for the hints on install location.


> add license file into your tar ball and spec at %doc 

Interestingly, nothing in the source tarball confirms the "License: GPLv2" tag. There is no COPYING file, and even if there were one, clarification would be highly recommended:

  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification


Consider running "fedora-review -b 1084190" to let that tool perform many helpful checks. It's a tool not only for reviewers. It finds a few things for this package, such as:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

Thanks, I will verify all you note.

Updated with feedback

Spec URL: http://elsupergomez.fedorapeople.org/SPECS/hamekoz-tiempos.spec
SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/hamekoz-tiempos-0.1.1-1.fc20.src.rpm

Firstly there is a issue that:

Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros


Secondly there is gtk-gui cs files. You may add license to them. While packaging their contents will not be changed. 

Third and last one is about : /usr/lib/hamekoz-tiempos (Directories without known owners)
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Thanks  Kazım SARIKAYA

First point fixed.
Second point, the files in gtk-gui are auto generated by Stetic GUI tool, if I add license it will be removes by de tool when files will regenerate.
Third point, I add dir in %files, think that resolve the problem. I'm right?

Spec URL: http://elsupergomez.fedorapeople.org/SPECS/hamekoz-tiempos.spec
SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/hamekoz-tiempos-0.1.1-2.fc20.src.rpm

your package is seemed good for me. now you should start to find a sponsor for your package.

Taking for formal review.
I've a question though, why having disabled debug_package?

The first try to package I had  problemas, and disabled.
I just check again, enabling again, and work fine.

http://elsupergomez.fedorapeople.org/SPECS/hamekoz-tiempos.spec
http://elsupergomez.fedorapeople.org/SRPMS/hamekoz-tiempos-0.1.1-3.fc20.src.rpm

It is correct now?
I put it into copr http://copr.fedoraproject.org/coprs/elsupergomez/hamekoz/

Any feedback??

v0.1.1-3 doesn't build to me in mock+rawhide. I add te build.log.

Created attachment 926374 [details]
Failed build: 0.1.1-3 with mock + rawhide

Updated, please check again.

SPEC http://elsupergomez.fedorapeople.org/SPECS/hamekoz-tiempos.spec
SRPC https://elsupergomez.fedorapeople.org/SRPMS/hamekoz-tiempos-0.1.1-6.fc21.src.rpm
COPR http://copr.fedoraproject.org/coprs/elsupergomez/hamekoz/