Bug 1084444

Summary:	[BUG] Quality of service does just apply to protocol "ip" instead of the device
Product:	[Community] Virtualization Tools	Reporter:	Sven Kieske <s.kieske>
Component:	libvirt	Assignee:	Michal Privoznik <mprivozn>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, mprivozn
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1084477 (view as bug list)		Environment:
Last Closed:	2014-04-07 09:44:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1084448, 1084477

Description Sven Kieske 2014-04-04 11:07:34 UTC

Description of problem:
when you specify qos settings according to:
http://libvirt.org/formatnetwork.html#elementQoS
this only gets applied for ipv4 traffic and not e.g. for ipv6
traffic or any other non-ip protocol

Version-Release number of selected component (if applicable):
I guess latest master should still not correctly implement this feature

How reproducible:
always

Steps to Reproduce:
1.define network qos as described above
2. test inside the vm, e.g. ftp with ip dual stack (v4 and v6)
3. watch qos being ignored for v6 traffic

Actual results:
qos gets just applied to deprecated ipv4 protcol

Expected results:
qos gets applied to the whole device, regardless which protocol is used

Additional info:
also backported feature in el6 is affected, also qos in downstream products like
ovirt is affected, as it relies on the libvirt functionality.
reproduced with libvirt-0.10.2-29.el6_5.3.x86_64

Comment 1 Antoni Segura Puimedon 2014-04-04 13:47:47 UTC

Patch proposal posted:
https://www.redhat.com/archives/libvir-list/2014-April/msg00210.html

Comment 2 Michal Privoznik 2014-04-07 09:44:59 UTC

I've just pushed the patch upstream:

commit d9de144385201d66929bf10e1941e30ba43fd746
Author:     Antoni S. Puimedon <asegurap>
AuthorDate: Fri Apr 4 15:39:33 2014 +0200
Commit:     Michal Privoznik <mprivozn>
CommitDate: Mon Apr 7 11:35:29 2014 +0200

    QoS: make tc filters match all traffic
    
    Up until now the traffic control filters for the vNIC QoS were
    matching only ip traffic. For egress traffic that was unnoticed
    because the unmatched traffic would just go to the default htb class
    and be shaped anyway. For ingress, though, since the policing of the
    rate is done by the filter itself.
    
    The problem is solved by changing protocol to all and making anything
    match the filter.
    
    Bug-Url: https://bugzilla.redhat.com/1084444
    Signed-off-by: Antoni S. Puimedon <asegurap>
    Signed-off-by: Michal Privoznik <mprivozn>