Bug 1084680

Summary:	Review Request: liblockdep - Runtime locking correctness validator
Product:	[Fedora] Fedora	Reporter:	Robin Hack <rhack>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bblaskov, package-review, pspacek, rc040203
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-10 05:24:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robin Hack 2014-04-05 11:36:39 UTC

Spec URL: http://rhack.fedorapeople.org/liblockdep.spec
SRPM URL: http://rhack.fedorapeople.org/liblockdep-0.0.1-1.fc20.src.rpm 
Description: liblockdep is a tiny wrapper built around kernel/lockdep.c. The aim is to
provide the same functionality the kernel gets from lockdep to userspace.
Fedora Account System Username: rhack

Comment 1 Ralf Corsepius 2014-04-05 16:27:17 UTC

Quite a number of issues with this package:

[MUSTFIX]
1.building is non-verbose:
 make -j4
  CC FPIC            rbtree.o
  CC FPIC            common.o
  CC FPIC            preload.o   
  CC FPIC            lockdep.o

It's impossible to check this package is being built correctly from build.log.

2. Package ships static lib in main-package.
Shipping static libs is strongly discouraged in Fedora - Should you insist on shipping them, they must be shipped in separate *-static subpackage.

3. Shared library doesn't provide SONAME
# objdump -p usr/lib/liblockdep.so | grep SONAME

Please contact upstream to provide one.

4. The libraries are not installed %{_libdir}, as they are supposed to be:
# rpm -qlp liblockdep-0.0.1-1.fc20.x86_64.rpm
/usr/lib/liblockdep.a
/usr/lib/liblockdep.so

5. Package ships libraries, but doesn't ship corresponding headers.
Normally this doesn't make sense.


[CONSIDER]
6. Consider to split the package into <main>, *-devel and *-static.
Should you not want to split the program from the shared-lib into a separte *-devel package, then the <main> package must provide corresponding *-devel-provides.

Comment 2 Branislav Blaškovič 2014-04-07 12:00:14 UTC

Please consider to add man page for binary /usr/bin/lockdep.

Comment 3 Branislav Blaškovič 2014-04-07 12:06:54 UTC

I cannot see COPYING and README in spec file but it is in attached tar.gz.

You should add these to package as %doc.

Comment 4 Petr Spacek 2014-04-09 10:38:07 UTC

(In reply to Ralf Corsepius from comment #1)
> 5. Package ships libraries, but doesn't ship corresponding headers.
> Normally this doesn't make sense.

AFAIK this is single-purpose library. It is meant to be used by application developers only via LD_PRELOAD, no application should link with it.

See https://lwn.net/Articles/550889/ for details.

IMHO this is special-case and rules for *real* libraries should not be applied to this case so strictly.

Comment 5 Robin Hack 2014-04-09 11:04:34 UTC

Hi. I found that bug bz#1082763 exists. Then I probably close this bug as duplicate.

Comment 6 Robin Hack 2014-04-10 05:24:44 UTC


*** This bug has been marked as a duplicate of bug 1082763 ***