| Summary: | Review Request: php-theseer-autoload - A tool and library to generate autoload code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, shawn | ||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | php-theseer-autoload-1.14.2-1.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-05-03 19:55:49 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | 1084772 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2014-04-06 13:57:17 UTC
Created attachment 887977 [details]
fedora-review.txt
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1084777 --plugins PHP:off
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/pear/TheSeer(php-
theseer-fDOMDocument, php-theseer-directoryscanner)
Required pkg php-pear(%{pear_channel}/DirectoryScanner) already owns
"%dir %{pear_phpdir}/TheSeer"
This is a simple fix that can be done after initial import so I will not block acceptance because of this :)
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, just remove these after initial import.
I had to disable the PHP fedora-review plugin because my phpcompatinfo (version 2.26.0) would get stuck in an infinite loop when calculating its' information. The requires look correct based on the actual script files and package.xml though.
No blockers.
===== APPROVED =====
Thanks ! New Package SCM Request ======================= Package Name: php-theseer-autoload Short Description: A tool and library to generate autoload code Owners: remi Branches: f20 el6 epel7 InitialCC: Git done (by process-git-requests). php-theseer-autoload-1.14.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-theseer-autoload-1.14.1-1.fc20 php-theseer-autoload-1.14.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-theseer-autoload-1.14.1-1.el6 php-theseer-autoload-1.14.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-theseer-autoload-1.14.2-1.fc20 has been pushed to the Fedora 20 stable repository. php-theseer-autoload-1.14.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: php-theseer-autoload New Branches: f19 Owners: remi InitialCC: Git done (by process-git-requests). |