Bug 1084836

Created attachment 883444 [details]
An experimental patch of /etc/rc.d/init.d/pulp-server

Description of problem: 
/etc/rc.d/init.d/pulp-server does not follow the LSB init script
spec [1] and returns wrong exit code (1) with 'status' argument passed
when the service is stopped (is not running). This causes trouble to
monitor the pulp-server service from outside.

[root@rhua ~]# service pulp-server stop
Stopping httpd:                                            [  OK  ]
Stopping Qpid AMQP daemon:                                 [  OK  ]
Stopping mongod:                                           [  OK  ]
[root@rhua ~]# service pulp-server status; echo $?
mongod is stopped
1
[root@rhua ~]#

[1] http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html


Version-Release number of selected component (if applicable):

[root@rhua ~]# rpm -qf /etc/rc.d/init.d/pulp-server
pulp-0.0.263-43.el6_5.noarch
[root@rhua ~]#


How reproducible: Always

Steps to Reproduce:
1. service pulp-server stop
2. service pulp-server status; echo $?

Actual results: pulp-server exits with the exit code '1' when stopped.

Expected results: It should exits with the exit code '3' (means stopped).

Additional info:

I wrote an experimental patch may fix this issue.

pulp-server is modified version and pulp-server.save is original
in the following:

[root@rhua ~]# service pulp-server status
mongod (pid 23606) is running...
httpd (pid  23646) is running...
qpidd (pid  23613) is running...
[root@rhua ~]# echo $?
0
[root@rhua ~]# service pulp-server stop
Stopping httpd:                                            [  OK  ]
Stopping Qpid AMQP daemon:                                 [  OK  ]
Stopping mongod:                                           [  OK  ]
[root@rhua ~]# service pulp-server status; echo $?
mongod is stopped
httpd is stopped
qpidd is stopped
3
[root@rhua ~]# /etc/rc.d/init.d/pulp-server.save status ; echo $?
mongod is stopped
1
[root@rhua ~]# /etc/rc.d/init.d/pulp-server help; echo $?
Usage: pulp-server {init|start|stop|status|restart}   # I don't think this is an error but I'm not sure.
0
[root@rhua ~]#