Bug 1086677

Summary: add blockdev-add support with libiscsi backends
Product: Red Hat Enterprise Linux 7 Reporter: Sibiao Luo <sluo>
Component: qemu-kvmAssignee: Markus Armbruster <armbru>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: chayang, famz, hhuang, juzhang, kwolf, michen, pbonzini, qzhang, rbalakri, shyu, virt-maint, xfu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1087142 1159728 (view as bug list) Environment:
Last Closed: 2014-11-03 17:25:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 750801, 1159728    

Description Sibiao Luo 2014-04-11 09:55:10 UTC
Description of problem:
Just like drive-add support the libiscsi storage backends.

Version-Release number of selected component (if applicable):
host info:
# uname -r && rpm -q qemu-kvm
3.10.0-121.el7.x86_64
qemu-kvm-1.5.3-60.el7.x86_64
guest info:
# uname -r
3.10.0-121.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.prepare a libiscsi lun.
# qemu-img info iscsi://10.66.90.100:3260/iqn.2001-05.com.equallogic:0-8a0906-4c41f7d03-453f49b421052a57-s2-sluo-270305-1/0
image: iscsi://10.66.90.100:3260/iqn.2001-05.com.equallogic:0-8a0906-4c41f7d03-453f49b421052a57-s2-sluo-270305-1/0
file format: raw
virtual size: 50G (53697576960 bytes)
disk size: unavailable
2.launch a QEMU.
3.hotplug a disk using blockdev-add with libiscsi backends.
{ "execute": "blockdev-add", "arguments": {'options' : {'driver': 'raw', 'id':'drive-disk1', 'file': {'driver': 'file', 'filename': 'iscsi://10.66.90.100:3260/iqn.2001-05.com.equallogic:0-8a0906-4c41f7d03-453f49b421052a57-s2-sluo-270305-1/0'}, 'cache': { 'writeback': false, 'direct': true, 'no-flush': false }}} }

Actual results:
{ "execute": "blockdev-add", "arguments": {'options' : {'driver': 'raw', 'id':'drive-disk1', 'file': {'driver': 'file', 'filename': 'iscsi://10.66.90.100:3260/iqn.2001-05.com.equallogic:0-8a0906-4c41f7d03-453f49b421052a57-s2-sluo-270305-1/0'}, 'cache': { 'writeback': false, 'direct': true, 'no-flush': false }}} }
{"error": {"class": "GenericError", "desc": "could not open disk image drive-disk1: Could not open file: No such file or directory"}}

Expected results:
Just like drive-add support the libiscsi storage backends.
{"execute":"__com.redhat_drive_add","arguments": {"file":"iscsi://10.66.90.100:3260/iqn.2001-05.com.equallogic:0-8a0906-4c41f7d03-453f49b421052a57-s2-sluo-270305-1/0","format":"raw","id":"drive-data-disk1","aio":"native","werror":"stop","rerror":"stop"}}
{"return": {}}
{"execute":"device_add","arguments":{"driver":"virtio-scsi-pci","id":"scsi1","bus":"pci.0","addr":"0x8"}}
{"return": {}}
{"execute":"device_add","arguments":{"driver":"scsi-hd","drive":"drive-data-disk1","id":"data-disk1","bus":"scsi1.0"}}
{"return": {}}

Additional info:

Comment 1 Markus Armbruster 2014-11-03 17:25:34 UTC
blockdev-add is a work in progress upstream.  At this time, we intend to bring the results to RHEL-7 qemu-kvm-rhev, but not to qemu-kvm.

blockdev-add support for iscsi is being worked on upstream.  It should find its way into qemu-kvm-rhev via rebase or backport (bug 1159728).  We don't intend to backport it to qemu-kvm.