Bug 1087734

Created attachment 890302 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0

Created attachment 890303 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1087734
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

[!]: Package contains no bundled libraries without FPC exception.

     /usr/share/horde/imp/js/murmurhash3.js = 
         https://github.com/kazuyukitanimura/murmurhash-js

>     /**
>      * JS Implementation of MurmurHash3
>      *
>      * Original version:
>      * https://github.com/kazuyukitanimura/murmurhash-js
>      *
>      * Additions by Michael Slusarz <slusarz>

     It appears the original source has additions by horde.  The original source is MIT and this file still has the MIT license text in it.  If this is allowed, does that mean MIT should be listed in the license field as well?  This is probably more of a license question than a bundled library question/issue.





[!]: Requires correct, justified where necessary.

     Per package.xml, update
         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.0.0
     to
         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.1.0
     
     
     Per package.xml, update
         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.0.0
     to
         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.2.0
     
     
     Per package.xml, add
         Requires:       php-pear(%{pear_channel}/Horde_Text_Filter_Csstidy) < 3.0.0
     
     
     Update comment
         # Optional and implicitly required:
         #     Horde_Vfs, Horde_History, Horde_Http, Horde_Stream_Filter
     to
         # Optional and implicitly required:
         #     Horde_History, Horde_Http
     
     
     Per phpcompatinfo, I do not see "php-ereg" or "php-posix" dependencies.





The HTTP config has "<DirectoryMatch %{pear_hordedir}/%{pear_name}/(config|lib|locale)>", but the "templates" directory has the same .htaccess file contents that the listed directories have so shouldn't it be added in the config as well?

Good catch !

https://github.com/remicollet/remirepo/commit/14f2b9bd6182eb35e75497aa22b3b8c7571905eb


Spec: https://raw.githubusercontent.com/remicollet/remirepo/14f2b9bd6182eb35e75497aa22b3b8c7571905eb/php/horde/php-horde-imp/php-horde-imp.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-imp-6.1.7-2.remi.src.rpm

[x]: Package contains no bundled libraries without FPC exception.

     This was a license issue/update, not a bundled library issue/update.

[x]: Requires correct, justified where necessary.


HTTPD config updated.


No blockers.


===== APPROVED =====

Thanks!

New Package SCM Request
=======================
Package Name: php-horde-imp
Short Description: A web based webmail system
Owners: remi
Branches: f20 el6 epel7
InitialCC:

Git done (by process-git-requests).

Build in rawhide + epel7

Will push all the horde applications at the same time (when all will be reviewed) in f20 / epel6

php-horde-imp-6.1.7-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-imp-6.1.7-2.el6

php-horde-imp-6.1.7-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-horde-imp-6.1.7-2.fc20

php-horde-imp-6.1.7-2.fc20 has been pushed to the Fedora 20 stable repository.

php-horde-imp-6.1.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository.