Bug 1087871

Summary:	kieResources.newFileSystemResource(File) should also support specifying the encoding for portability reasons
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Geoffrey De Smet <gdesmet>
Component:	BRE	Assignee:	Mario Fusco <mfusco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Marek Winkler <mwinkler>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	6.0.2	CC:	kverlaen, lpetrovi, rrajasek
Target Milestone:	ER2
Target Release:	6.0.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-06 19:53:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Geoffrey De Smet 2014-04-15 13:38:48 UTC

All KieResources methods have an overloaded method with a String encoding parameter, for example:
  Resource newInputStreamResource(InputStream in);
  Resource newInputStreamResource(InputStreamin, String encoding);

Except for:
  Resource newFileSystemResource(File file);

Requirements: Add a method:
  Resource newFileSystemResource(File file, String encoding);


If no encoding is specified, the encoding defaults to the platform default (windows-1252 on windows, UTF-8 on linux). This causes portability issues: a DRL file that works perfectly on the developers machine might not work on the production machine - if they use different operation systems.

Comment 2 Mario Fusco 2014-04-15 18:02:17 UTC

Fixed by https://github.com/droolsjbpm/droolsjbpm-knowledge/commit/1afbceb35 and https://github.com/droolsjbpm/drools/commit/49dfc2fc1

Comment 3 Mario Fusco 2014-04-15 18:05:14 UTC

Cherry-picked to 6.0.x branch with https://github.com/droolsjbpm/droolsjbpm-knowledge/commit/2df5d8408 and https://github.com/droolsjbpm/drools/commit/3e755c457

Comment 4 Marek Winkler 2014-05-06 10:29:30 UTC

Verified on BRMS 6.0.2 ER2.