Bug 1088616

Summary: [GSS] (6.2.x) Messages always acked individually after certain reconnection scenarios
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Jimmy Wilson <jawilson>
Component: HornetQAssignee: Clebert Suconic <csuconic>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Svehla <msvehla>
Severity: unspecified Docs Contact: Lucas Costi <lcosti>
Priority: unspecified    
Version: 6.2.1CC: csuconic, lcosti, msvehla
Target Milestone: CR2   
Target Release: EAP 6.2.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
The client consumer would always ack messages individually in certain scenarios, for example after failures. This process was very inefficient. In this release of JBoss EAP 6, optimizations were added to the client consumer implementation to address this inefficiency.
Story Points: ---
Clone Of:
: 1089849 (view as bug list) Environment:
Last Closed: 2014-06-09 12:48:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1089849    
Bug Blocks: 1067532, 1084639    

Description Jimmy Wilson 2014-04-16 21:25:34 UTC

Comment 1 Martin Svehla 2014-05-06 15:18:20 UTC
There doesn't seem to be any commit related to this in 2.3.14.1

Clebert, can you point me to the right commit please? Perhaps it was commited together with some other changes?

Comment 2 Clebert Suconic 2014-05-06 15:30:16 UTC
Yes.. it was together with another commit:


This commit here was just adding a test:

https://github.com/hornetq/hornetq/commit/d24cd45



However if you look at the change on ClientConsumerImpl, if message.containsProperty(ClientConsumerImpl.FORCED_DELIVERY_MESSAGE), it would set ackIndividually forever.. what was happening after failover.


I realized this after these tests and i improved the check.

Comment 3 Martin Svehla 2014-05-07 06:28:52 UTC
Thanks Cleberet! Much appreciated.

Comment 4 Martin Svehla 2014-05-07 06:29:58 UTC
Sorry about the typo

Comment 5 Martin Svehla 2014-05-07 07:25:42 UTC
Verified with EAP 6.2.3.CP.CR2 / HornetQ 2.3.14.1.Final