Bug 1088854
| Summary: | /usr/bin/g77 should be removed from BR unconditionally | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaromír Cápík <jcapik> |
| Component: | automake | Assignee: | Pavel Raiskup <praiskup> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dan, ovasik, phracek, praiskup |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | automake-1.14.1-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-17 12:42:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Jaromir, thanks for the report. (In reply to Jaromír Cápík from comment #0) > Description of problem: > > Hello. > > The automake build conditionally depends on /usr/bin/g77 ... Truth. > But it seems it doesn't serve it's purpose for 2 reasons ... > > 1.) I tried to build automake with and without g77 and the resulting RPMs > did NOT differ at all. Yep, expected. There are some g77 tests in automake's upstream testsuite conditionally enabled if g77 is installed. > 2.) ifarch conditions should NOT be present in noarch builds as they cannot > be evaluated correctly in koji/mock. I don't understand this sentence. What cannot be evaluated correctly? If the g77 carrying package is available, it is installed - and then tested by %check. > Please, remove the /usr/bin/g77 BuildRequires as well as the ifnarch > condition. Please explain the benefits of this removal, are we going to drop g77 tests for all architectures? If I could force koji to always choose i686/x86_64 builder, I could remove the %ifarch.. Pavel (In reply to Pavel Raiskup from comment #1) > Jaromir, thanks for the report. > > (In reply to Jaromír Cápík from comment #0) > > Description of problem: > > > > Hello. > > > > The automake build conditionally depends on /usr/bin/g77 ... > > Truth. > > > But it seems it doesn't serve it's purpose for 2 reasons ... > > > > 1.) I tried to build automake with and without g77 and the resulting RPMs > > did NOT differ at all. > > Yep, expected. There are some g77 tests in automake's upstream testsuite > conditionally enabled if g77 is installed. > > > 2.) ifarch conditions should NOT be present in noarch builds as they cannot > > be evaluated correctly in koji/mock. > > I don't understand this sentence. What cannot be evaluated correctly? If > the > g77 carrying package is available, it is installed - and then tested by > %check. > > > Please, remove the /usr/bin/g77 BuildRequires as well as the ifnarch > > condition. > > Please explain the benefits of this removal, are we going to drop g77 tests > for all architectures? If I could force koji to always choose i686/x86_64 > builder, I could remove the %ifarch.. don't forget that koji is not only about i686/x86_64 vs. arm, but also about aarch64, s390(s), ppc/ppc64 and now ppc64le and we don't what will come in in the future > > Please explain the benefits of this removal, are we going to drop g77 tests
> > for all architectures? If I could force koji to always choose i686/x86_64
> > builder, I could remove the %ifarch..
>
> don't forget that koji is not only about i686/x86_64 vs. arm, but also about
> aarch64, s390(s), ppc/ppc64 and now ppc64le and we don't what will come in
> in the future
I'm sure removing the %ifnarch is no go - actually I was asked to put there
aarch64 some time ago just because of automake rebuild on that architecture.
What I am not sure is whether it is worth to disable some test cases which are
usually run in koji (if the arm builder is not choosen). What is the real
purpose for this request?
Pavel
Oh, I see, it took some time but I got it! The %ifnarch macro always compares arguments with "noarch" string for noarch packages. I can imagine only _really_ ugly workarounds, so the commit: http://pkgs.fedoraproject.org/cgit/automake.git/commit/?id=47ffbf12eceab |
Description of problem: Hello. The automake build conditionally depends on /usr/bin/g77 ... --- %ifnarch %{arm} aarch64 # g77 is also not present on arm systems BuildRequires: /usr/bin/g77 %endif --- But it seems it doesn't serve it's purpose for 2 reasons ... 1.) I tried to build automake with and without g77 and the resulting RPMs did NOT differ at all. 2.) ifarch conditions should NOT be present in noarch builds as they cannot be evaluated correctly in koji/mock. Please, remove the /usr/bin/g77 BuildRequires as well as the ifnarch condition. Version-Release number of selected component (if applicable): automake-1.14.1-1.fc21