Bug 1089108

Summary: File Systems -> Free Space graph off by a factor of 1000
Product: [Other] RHQ Project Reporter: Mike Thompson <mithomps>
Component: Core UIAssignee: Mike Thompson <mithomps>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: urgent    
Version: 4.10CC: fbrychta, hrupp
Target Milestone: ---   
Target Release: RHQ 4.11   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1091555 (view as bug list) Environment:
Last Closed: 2014-07-21 10:14:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1091555    
Attachments:
Description Flags
Screen shot of YAxis scale and bars issues. none

Description Mike Thompson 2014-04-18 01:01:20 UTC 
Description of problem:
This is a recent regression just introduced by BZ1080470. I have only seen it here but it is possible that it is in other places.


Version-Release number of selected component (if applicable):
4.11


How reproducible: 
Always


Steps to Reproduce:
1.Goto Inventory --> File Systems --> Monitor --> Free space (graph)


Actual results:
Graph has wrong YAxis scale (off by 1000) and the values are off by the same.


Expected results:
Correct results.


Additional info:
Comment 1 Mike Thompson 2014-04-18 01:02:34 UTC 
Created attachment 887383 [details]
Screen shot of YAxis scale and bars issues.
Comment 2 Mike Thompson 2014-04-24 01:06:34 UTC 
Discovered that this problem also exists with time measurementUnits. Making the severity worse.
Comment 3 Mike Thompson 2014-04-24 02:14:59 UTC 
Committed to master:

commit 251d60aa898402d28338a43bc844a3d69d4aff7d
Author: Mike Thompson <mithomps>
Date:   Wed Apr 23 19:02:53 2014 -0700

    [BZ 1089108] File Systems -> Free Space graph off by a factor of 1000. This was due to a recent bug fix introduced for BZ1080470.



Testing Instructions:
Please test various metrics as it is possible that other metrics are affected. I have run though many metrics this afternoon but just in case please do a test of various resource/metrics combinations.
Comment 4 Mike Thompson 2014-04-25 18:07:28 UTC 
Refactored solution to a cleaner, more maintainable solution with no if conditions.

Committed to master:

commit a2f0529d82120e069b22c94558d07f9e3a811e44
Author: Mike Thompson <mithomps>
Date:   Fri Apr 25 11:01:28 2014 -0700

    [BZ 1089108] File Systems -> Free Space graph off by a factor of 1000. Refactored to a much cleaner solution with no IF logic. Removed some dead code from Measurement helper classes.
Comment 5 Filip Brychta 2014-04-29 10:24:58 UTC 
Verified on
Version :	
4.11.0-SNAPSHOT
Build Number :	
e686783
Comment 6 Heiko W. Rupp 2014-07-21 10:14:04 UTC 
Bulk closing of RHQ 4.11 issues, now that RHQ 4.12 is out.

If you find an issue with those, please open a new BZ, linking to the old one.