Bug 1089597

Summary: Meld couldn't save changes
Product: [Fedora] Fedora EPEL Reporter: Mikhail <mikhail.v.gavrilov>
Component: meldAssignee: Lubomir Rintel <lkundrak>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel7CC: c.david86, gilboad, lkundrak, mikhail.v.gavrilov, pchilds, wqbbs911
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mikhail 2014-04-21 06:20:59 UTC
Description of problem:
Meld couldn't save changes.
Demonstration: https://drive.google.com/file/d/0B0nwzlfiB4aQakotMG5hMWhIUnc/edit?usp=sharing

Comment 1 Mikhail 2014-04-21 06:41:19 UTC
Yet another demo: https://drive.google.com/file/d/0B0nwzlfiB4aQVmEtbW4zMXM1NU0/edit?usp=sharing

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/meld/meldwindow.py", line 558, in <lambda>
    lambda b: self.try_remove_page(page))
  File "/usr/lib/python2.7/site-packages/meld/meldwindow.py", line 526, in try_remove_page
    response = page.on_delete_event(appquit)
  File "/usr/lib/python2.7/site-packages/meld/filediff.py", line 895, in on_delete_event
    response = self.check_save_modified()
  File "/usr/lib/python2.7/site-packages/meld/filediff.py", line 888, in check_save_modified
    if not self.save_file(i):
  File "/usr/lib/python2.7/site-packages/meld/filediff.py", line 1651, in save_file
    extrabuttons=[ buttons[b] for b in bufdata.newlines ] )
  File "/usr/lib/python2.7/site-packages/meld/misc.py", line 83, in run_dialog
    d.image.set_alignment(0.5, 0)
AttributeError: 'MessageDialog' object has no attribute 'image'

Comment 2 Dominic Hopf 2014-08-22 20:29:30 UTC
Can you check if this issue is still present for you with the latest updates for Meld?

Comment 3 wqbbs911 2014-11-21 07:33:44 UTC
Reproducted this issue in mercurial with meld on centos 7  system.

Comment 4 Fedora End Of Life 2015-05-29 11:37:51 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Paul Childs 2015-06-10 22:50:45 UTC
No do NOT delete it.
As described above, the bug also occurs on CentOS 7 so EOL is not applicable, could the assignee please change over these details so the bug is not incorrectly deleted.

On my system (also CentOS 7) I believe the bug occurs as a result of a dialogue window due to mixed line endings ocurring in the file (which explains why I notice it intermittently)

The crash itself is the identical error as Mikhael gets (misc.py:83).

My version is meld-3.11.0-1.el7.2

Comment 6 Dominic Hopf 2015-06-11 07:40:57 UTC
There shortly will be an update to Meld 3.13.1 available:

http://koji.fedoraproject.org/koji/buildinfo?buildID=640746

Can you test if this fixes the issue for you?

Thanks & Regards,
Dominic