Bug 1089906

Summary: [SNAPSHOT]: Restore is successful even when peer glusterd/nodes are down.
Product: [Community] GlusterFS Reporter: Avra Sengupta <asengupt>
Component: glusterdAssignee: Avra Sengupta <asengupt>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: pre-releaseCC: asengupt, bugs, gluster-bugs, josferna, nlevinki, rhinduja, shaines, ssamanta
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: SNAPSHOT
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1067342 Environment:
Last Closed: 2014-11-11 08:30:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1067342    
Bug Blocks:    

Comment 1 Anand Avati 2014-04-22 08:20:27 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores) posted (#7) for review on master by Avra Sengupta (asengupt)

Comment 2 Anand Avati 2014-04-22 15:56:33 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores.) posted (#8) for review on master by Avra Sengupta (asengupt)

Comment 3 Anand Avati 2014-04-24 14:30:39 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores.) posted (#9) for review on master by Avra Sengupta (asengupt)

Comment 4 Anand Avati 2014-04-25 04:25:50 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores.) posted (#10) for review on master by Avra Sengupta (asengupt)

Comment 5 Anand Avati 2014-04-25 15:25:48 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores.) posted (#11) for review on master by Avra Sengupta (asengupt)

Comment 6 Anand Avati 2014-04-28 07:31:00 UTC
REVIEW: http://review.gluster.org/7455 (glusterd/snapshot: Perform missed snap deletes and restores.) posted (#12) for review on master by Avra Sengupta (asengupt)

Comment 7 Anand Avati 2014-04-28 10:50:33 UTC
COMMIT: http://review.gluster.org/7455 committed in master by Vijay Bellur (vbellur) 
------
commit 5d9172e0b3e14795db7aba321cfcac428a201399
Author: Avra Sengupta <asengupt>
Date:   Mon Apr 7 06:02:10 2014 +0000

    glusterd/snapshot: Perform missed snap deletes and restores.
    
    Replacing is_volume_restored(gf_boolean_t) with
    restored_from_snap(uuid_t) in glusterd_volinfo_
    
    Also removed gd_restore_snap_volume from glusterd-volgen.c
    to glusterd-snapshot.c
    
    Change-Id: Ic615a1658cfaffa98d4590506ac82f20bf709ad6
    BUG: 1089906
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/7455
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 8 Niels de Vos 2014-09-22 12:38:23 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 9 Niels de Vos 2014-11-11 08:30:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users