Bug 1090042

Summary: [SNAPSHOT]: Able to create snapshot when one of the brick is down even without force
Product: [Community] GlusterFS Reporter: Joseph Elwin Fernandes <josferna>
Component: glusterdAssignee: Joseph Elwin Fernandes <josferna>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: pre-releaseCC: bugs, gluster-bugs, josferna, rhinduja, sankarshan, ssamanta
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: SNAPSHOT
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1089527 Environment:
Last Closed: 2014-11-11 08:30:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1089527    
Bug Blocks:    

Description Joseph Elwin Fernandes 2014-04-22 12:49:48 UTC
+++ This bug was initially created as a clone of Bug #1089527 +++

Description of problem:
=======================
we decided to fail the snapshot create when any of the brick is down until force is applied to the CLI. But when a brick is down, I am able to create a snapshot of a volume.

[root@snapshot09 ~]# gluster volume status vol3
Status of volume: vol3
Gluster process                                         Port    Online  Pid
------------------------------------------------------------------------------
Brick snapshot09.lab.eng.blr.redhat.com:/brick3/b3      49155   Y       12498
Brick snapshot10.lab.eng.blr.redhat.com:/brick3/b3      N/A     N       9069
Brick snapshot11.lab.eng.blr.redhat.com:/brick3/b3      49155   Y       5187
Brick snapshot12.lab.eng.blr.redhat.com:/brick3/b3      49155   Y       5082
NFS Server on localhost                                 2049    Y       13272
Self-heal Daemon on localhost                           N/A     Y       13279
NFS Server on snapshot10.lab.eng.blr.redhat.com         2049    Y       9761
Self-heal Daemon on snapshot10.lab.eng.blr.redhat.com   N/A     Y       9768
NFS Server on snapshot11.lab.eng.blr.redhat.com         2049    Y       5842
Self-heal Daemon on snapshot11.lab.eng.blr.redhat.com   N/A     Y       5849
NFS Server on snapshot12.lab.eng.blr.redhat.com         2049    Y       5738
Self-heal Daemon on snapshot12.lab.eng.blr.redhat.com   N/A     Y       5745
 
Task Status of Volume vol3
------------------------------------------------------------------------------
There are no active volume tasks
 
[root@snapshot09 ~]# gluster snapshot create rrr1 vol3
snapshot create: rrr1: snap created successfully
[root@snapshot09 ~]# 
[root@snapshot09 ~]# 
[root@snapshot09 ~]# gluster snapshot list vol3
rrr1
[root@snapshot09 ~]# 



Version-Release number of selected component (if applicable):
=============================================================

glusterfs-libs-3.5qa2-0.340.gitc193996.el6rhs.x86_64


How reproducible:
=================
1/1


Steps to Reproduce:
===================
1. Create and start volume
2. Kill one of the brick of volume
3. Create a snapshot of a volume

Actual results:
===============

Snapshot creation is successful.


Expected results:
=================
Snapshot creation should fail until force is applied.

--- Additional comment from Nagaprasad Sathyanarayana on 2014-04-21 02:17:56 EDT ---

Marking snapshot BZs to RHS 3.0.

--- Additional comment from Joseph Elwin Fernandes on 2014-04-21 23:49:38 EDT ---

Fixed in http://review.gluster.org/#/c/7520/

Comment 1 Anand Avati 2014-04-22 12:52:15 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#3) for review on master by Joseph Fernandes (josferna)

Comment 2 Anand Avati 2014-04-24 03:35:14 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#4) for review on master by Joseph Fernandes (josferna)

Comment 3 Anand Avati 2014-04-24 03:46:55 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#5) for review on master by Joseph Fernandes (josferna)

Comment 4 Anand Avati 2014-04-24 11:12:25 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#6) for review on master by Joseph Fernandes (josferna)

Comment 5 Anand Avati 2014-04-24 13:18:16 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#7) for review on master by Joseph Fernandes (josferna)

Comment 6 Anand Avati 2014-04-25 11:57:41 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#8) for review on master by Joseph Fernandes (josferna)

Comment 7 Anand Avati 2014-04-25 12:25:55 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#9) for review on master by Joseph Fernandes (josferna)

Comment 8 Anand Avati 2014-04-29 13:09:52 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#10) for review on master by Rajesh Joseph (rjoseph)

Comment 9 Anand Avati 2014-04-29 13:14:08 UTC
REVIEW: http://review.gluster.org/7520 ([glusterd/snapshot] snapshot create force option) posted (#11) for review on master by Rajesh Joseph (rjoseph)

Comment 10 Anand Avati 2014-05-01 06:27:35 UTC
COMMIT: http://review.gluster.org/7520 committed in master by Vijay Bellur (vbellur) 
------
commit f63fbca7540a4c9ce090e1ed5941ed8777ff6316
Author: Joseph Fernandes <josferna>
Date:   Mon Apr 21 20:28:22 2014 +0530

    [glusterd/snapshot] snapshot create force option
    
    Implement force option in snapshot create i.e
    
    1) Creation of snapshot fails if the original volume
    bricks are down
    2) With a force option creation of snapshot will continue
    even if the original volume bricks are down.
    
    This was the fix for bugs 1089527 and 1083502
    
    Change-Id: I8de0242adf8ee0af00db9fa8701d86fabc12e7fc
    BUG: 1090042
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/7520
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 11 Niels de Vos 2014-09-22 12:38:28 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 12 Niels de Vos 2014-11-11 08:30:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users