Bug 1090047

Summary: [SNAPSHOT]: Glusterd crashes when a same command eg snapshot create is fired simultaneously on a node
Product: [Community] GlusterFS Reporter: Joseph Elwin Fernandes <josferna>
Component: glusterdAssignee: Joseph Elwin Fernandes <josferna>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: pre-releaseCC: asengupt, bugs, gluster-bugs, rabhat, rhinduja, rjoseph, sankarshan, senaik, spandit, vmallika
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: SNAPSHOT
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1088338 Environment:
Last Closed: 2014-11-11 08:30:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1088338    
Bug Blocks:    

Comment 1 Anand Avati 2014-04-22 13:11:52 UTC
REVIEW: http://review.gluster.org/7500 ([glusterd/snapshot] Glusterd crashes when a same command eg snapshot create is fired simultaneously on a node) posted (#2) for review on master by Joseph Fernandes (josferna)

Comment 2 Anand Avati 2014-04-23 04:33:07 UTC
REVIEW: http://review.gluster.org/7500 ([glusterd/snapshot] Glusterd crashes when a same command eg snapshot create is fired simultaneously on a node) posted (#3) for review on master by Joseph Fernandes (josferna)

Comment 3 Anand Avati 2014-04-23 04:36:01 UTC
REVIEW: http://review.gluster.org/7500 ([glusterd/snapshot] Glusterd crashes when a same command eg snapshot create is fired simultaneously on a node) posted (#4) for review on master by Joseph Fernandes (josferna)

Comment 4 Anand Avati 2014-04-30 16:12:25 UTC
COMMIT: http://review.gluster.org/7500 committed in master by Vijay Bellur (vbellur) 
------
commit 48043e3c11921a6cac532f2e56ccca6b72539dba
Author: Joseph Fernandes <josferna>
Date:   Thu Apr 17 19:42:06 2014 +0530

    [glusterd/snapshot] Glusterd crashes when a same command
    eg snapshot create is fired simultaneously on a node
    
    Cause: In glusterd_mgmt_v3_initiate_snap_phases() , the function
    glusterd_mgmt_v3_post_validate() asserts on the NULL value of
    req_dic. req_dic is not initialized as
    glusterd_mgmt_v3_initiate_lockdown() is not able to acquire the lock
    and comes to the "out" section, before initializing req_dic
    (via glusterd_mgmt_v3_build_payload)
    
    Fix: Call glusterd_mgmt_v3_post_validate() only if the lock is
    acquired.
    
    Change-Id: I7cb55b6c0013ad1c8bbb922a62c34aab097bafe9
    BUG: 1090047
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/7500
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2014-09-22 12:38:31 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 6 Niels de Vos 2014-11-11 08:30:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users