Bug 109025

Summary:	Checklist class should allow additional checks to be provided without requiring Java source code changes
Product:	[Retired] Red Hat Web Application Framework	Reporter:	Daniel Berrangé <berrange>
Component:	other	Assignee:	Rafael H. Schloming <rafaels>
Status:	CLOSED RAWHIDE	QA Contact:	Jon Orris <jorris>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	nightly	CC:	richardl, tross
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2003-12-02 22:43:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	109665, 110348

Description Daniel Berrangé 2003-11-04 15:37:47 UTC

Description of problem:

The c.a.packaging.Checklist class contains a number of checks for
items such as JAAS / JCE jars, DB driver, etc. Unfortunately all these
checks are implemented as private methods of the class and there is no
mechanism for providing news checks which doesn't involve hacking the
source. 

Checklist should be fixed such that each 'check' is encapsulated in
its own 'plugin' class. A config mechanism would be used to register
validation plugins with the tool, enabling new tests to be trivially
added as problems come to light. This would also enable projects to
plugin customer/project specific checks without forking the code.
Without this capability, the Checklist tool is severely limited in its
usefullness.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Daniel Berrangé 2003-11-04 15:38:25 UTC

bug 98494 contains a growing list of items to check

Comment 2 Richard Li 2003-11-21 14:40:46 UTC

-> bstein for clarification as per email

Comment 3 Richard Li 2003-11-21 17:41:07 UTC

bstein says:

A check needs to have some metadata associated with it:

   * Package with which it is associated (ie, forum / atoz / etc)
   * Point at which to run. (ie, pre-DB load, pre-Java load,
pre-Hostinit, pre-Startup).

Comment 4 Rafael H. Schloming 2003-12-02 22:25:52 UTC

This should be implemented now as of change 38433. See the javadoc for
com.arsdigita.packaging.Check for details on the use of this feature.

Comment 5 Rafael H. Schloming 2003-12-02 22:30:14 UTC

One more thing I forgot, even though the javadoc says that the checks
of type "startup" are done on server startup this currently doesn't
happen, they are only actually run by the ccm status command. If we
want them to be run on server start we should generate a ticket for
dennis to make ccm start do the equivalent of running ccm status.