Bug 1090757

Summary:	Puppet-Gluster should run fstrim when doing thin-p
Product:	[Community] GlusterFS	Reporter:	James (purpleidea) <jshubin>
Component:	puppet-gluster	Assignee:	James (purpleidea) <jshubin>
Status:	CLOSED EOL	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	pre-release	CC:	bugs, jshubin, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-10-22 15:40:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James (purpleidea) 2014-04-24 05:52:43 UTC

Description of problem:

As discussed in this thread:
http://lists.nongnu.org/archive/html/gluster-devel/2014-04/msg00201.html

Puppet-Gluster should (could?) add a cron job to periodically run fstrim, when using thin-p.

This bug has been created to keep track of the specific requirements, and recommended defaults.

I've written a preliminary (aka completely untested) patch, which I'll modify as I get more information.

https://github.com/purpleidea/puppet-gluster/tree/feat/fstrim

Currently this should run fstrim once a day at 23:00h with no arguments other than the mounted file system path. Is this correct? Should it be pointing to a lvm device instead?

Comments appreciated.

Cheers,
James

Comment 1 James (purpleidea) 2014-04-24 05:57:53 UTC

PS: actual sha is:
https://github.com/purpleidea/puppet-gluster/commit/1444914fe5988cc285cd572e3ed1042365d58efd

Comment 3 James (purpleidea) 2014-09-30 16:26:41 UTC

Niels, either you're willing to patch/test this or your script has gone awry and is changing assignee when it's invalid to do so.

Comment 4 Kaleb KEITHLEY 2015-10-22 15:40:20 UTC

pre-release version is ambiguous and about to be removed as a choice.

If you believe this is still a bug, please change the status back to NEW and choose the appropriate, applicable version for it.