Bug 1091700

Summary:	remove/restore /var/lib/ovirt-engine-reports/build-conf on failure
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Yaniv Lavi <ylavi>
Component:	ovirt-engine-reports	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED ERRATA	QA Contact:	Barak Dagan <bdagan>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.4.0	CC:	aburden, acathrow, alonbl, gianluca.cecchi, gklein, iheim, pstehlik, Rhev-m-bugs, sherold, sradco, yeylon
Target Milestone:	---
Target Release:	3.4.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	integration
Fixed In Version:	av9 - rhevm-reports-3.4.0-9.el6ev.noarch.rpm	Doc Type:	Bug Fix
Doc Text:	* Previously, the build-conf files for ovirt-engine-reports would be partially deployed if the Red Hat Enterprise Virtualization Manager had a failed upgrade from 3.3 to 3.4. This meant that a subsequent attempt to upgrade would fail to upgrade reports. Now, the build-conf files are backed up upon upgrade. If there has been a failed upgrade attempt, subsequent upgrades will remove the partially deployed files, and restore the older files if necessary, and reports is upgraded as expected.	Story Points:	---
Clone Of:	1084749	Environment:
Last Closed:	2014-06-09 15:28:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1084749
Bug Blocks:	1102906

Description Yaniv Lavi 2014-04-27 12:12:14 UTC

+++ This bug was initially created as a clone of Bug #1084749 +++

Currently the build-conf is managed outside of the setup transaction, if upgrade from 3.3 fails, we leave it. Then next attempt assumes that 3.4 is available.

We should backup this directory before process and restore if setup fails, to avoid these cases.

Comment 2 Barak Dagan 2014-05-14 08:02:05 UTC

Verified on av9:

rhevm-3.4.0-0.18.el6ev.noarch
rhevm-dwh-3.4.0-9.el6ev.noarch
rhevm-reports-3.4.0-9.el6ev.noarch

 3.3 engine/dwh/reports setup
engine upgraded to 3.4
reports package updated to 3.4
engine-setup
killed ^C during 'exporting from jasper'
rolled back successfully
engine-setup
killed ^C during deploying jasper
rolled back successfully
engine-setup
finished successfully upgrading reports to 3.4
engine-setup
killed ^C during 'exporting from jasper'
rolled back successfully
engine-setup
killed ^C during deploying jasper
rolled back successfully
engine-setup
finished successfully upgrading reports (from 3.4 to 3.4)

Comment 3 errata-xmlrpc 2014-06-09 15:28:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-0602.html