Bug 1092037
| Summary: | Issues reported by Cppcheck static analysis tool | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Kaleb KEITHLEY <kkeithle> |
| Component: | core | Assignee: | Kaleb KEITHLEY <kkeithle> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 3.5.0 | CC: | glusterbugs, gluster-bugs, jshubin, kkeithle, lmohanty, ndevos |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1091677 | Environment: | |
| Last Closed: | 2015-06-03 21:08:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1091677, 1109180, 1122290, 1227808 | ||
| Bug Blocks: | 1141158 | ||
|
Description
Kaleb KEITHLEY
2014-04-28 14:46:57 UTC
REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#2) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) According to the buglifecycle , the bug state should be in POST. http://www.gluster.org/community/documentation/index.php/Bug_report_life_cycle REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#3) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#4) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#5) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#6) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#7) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#8) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#9) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) Moving out to 3.5.2. The patch(es) need to get merged in the master branch first. Really depends on bug 1091677 and bug 1109180 which fix these issues in master. The patch for bug 1109180 has not been merged yet, this is a prerequisite for merging the proposed change in release-3.5. The change for mainline has not been merged yet. I'm preparing a beta for glusterfs-3.5.3 without this change. Hopefully a fix will land in time for glusterfs-3.5.4. REVIEW: http://review.gluster.org/7605 (core: fix Ubuntu code audit (cppcheck) results) posted (#10) for review on release-3.5 by Kaleb KEITHLEY (kkeithle) COMMIT: http://review.gluster.org/7605 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 8ae5046eb6c86840ccecefbade1695e68055de33 Author: Kaleb S. KEITHLEY <kkeithle> Date: Tue Apr 29 15:12:46 2014 -0400 core: fix Ubuntu code audit (cppcheck) results See http://review.gluster.org/#/c/7583/ BZ 1086460 AFAICT these are false positives: [geo-replication/src/gsyncd.c:99]: (error) Memory leak: str [geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv [xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde Program exits, resource leak not an issue [extras/geo-rep/gsync-sync-gfid.c:105]: (error) Resource leak: fp Test program: [extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments. Not built: [xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv The remainder are fixed with this change-set: [heal/src/glfs-heal.c:357]: (error) Possible null pointer dereference: remote_subvol [libglusterfs/src/xlator.c:648]: (error) Uninitialized variable: gfid [libglusterfs/src/xlator.c:649]: (error) Uninitialized variable: gfid [xlators/cluster/afr/src/afr-inode-write.c:469]: (error) Possible null pointer dereference: frame [xlators/cluster/afr/src/afr-self-heal-common.c:1704]: (error) Possible null pointer dereference: local [xlators/cluster/dht/src/dht-rebalance.c:1643]: (error) Possible null pointer dereference: ctx [xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local [xlators/features/changelog/src/changelog.c:1464]: (error) Possible null pointer dereference: priv [xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1656]: (error) Possible null pointer dereference: command [xlators/mgmt/glusterd/src/glusterd-replace-brick.c:914]: (error) Resource leak: file [xlators/mgmt/glusterd/src/glusterd-replace-brick.c:998]: (error) Resource leak: file [xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx [xlators/mgmt/glusterd/src/glusterd-store.c:1332]: (error) Possible null pointer dereference: handle [xlators/mgmt/glusterd/src/glusterd-utils.c:4706]: (error) Possible null pointer dereference: this [xlators/mgmt/glusterd/src/glusterd-utils.c:5613]: (error) Possible null pointer dereference: this [xlators/mgmt/glusterd/src/glusterd-utils.c:6342]: (error) Possible null pointer dereference: path_tokens [xlators/mgmt/glusterd/src/glusterd-utils.c:6343]: (error) Possible null pointer dereference: path_tokens [xlators/mount/fuse/src/fuse-bridge.c:4591]: (error) Uninitialized variable: finh [xlators/mount/fuse/src/fuse-bridge.c:3004]: (error) Possible null pointer dereference: state [xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it). [xlators/performance/quick-read/src/quick-read.c:585]: (error) Possible null pointer dereference: iobuf Rerunning cppcheck afterwards: As before, test program: [extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments. As before, believed to be false positive: [geo-replication/src/gsyncd.c:99]: (error) Memory leak: str [geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv [xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde As before, not built: [xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv False positive after fix: [heal/src/glfs-heal.c:356]: (error) Possible null pointer dereference: remote_subvol [xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local Change-Id: Ib3029d3223f5a13e2ac386a527d64d5ffe3ecb90 BUG: 1092037 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/7605 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.4, please reopen this bug report. glusterfs-3.5.4 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/2 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |