Bug 1092143

Summary: Content views that fail to publish should not have "promote" button.
Product: Red Hat Satellite Reporter: Corey Welton <cwelton>
Component: Users & RolesAssignee: Brad Buckingham <bbuckingham>
Status: CLOSED CURRENTRELEASE QA Contact: Tazim Kolhar <tkolhar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.3CC: bbuckingham, cwelton, jmontleo, tkolhar
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/6913
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-11 12:22:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
publish failed promote button is disabled none

Description Corey Welton 2014-04-28 19:55:01 UTC 
Description of problem:
Sometimes (for whatever reason?) a content view publish action fails.  This is visible in the UI and has a red status bar, etc -- but the "promote" button remains.

We should require that any content view have a check that the most recent publish attempt was successful before displaying/enabling the promote button.  There should probably be a help bubble explaining why promotion might be disabled.

Version-Release number of selected component (if applicable):
Satellite-6.0.3-RHEL-6-20140423.1

How reproducible:


Steps to Reproduce:
1.  Attempt to publish a CV but assure this publish fails (how??)
2.  View the results and click the 'Promote' button.
3.  View results.

Actual results:

In this case I got 
required lock: #<ForemanTasks::Lock:0x007fd9a4e3e858> conflicts wiht [#<ForemanTasks::Lock id: 224, task_id: "e0bfaa22-52f9-4cef-abe9-d0ad02afe30e", name: "read", resource_type: "Katello::ContentView", resource_id: 3, exclusive: true>]".



Expected results:
I am not sure how relevant/useful error message above is for the bz, but in any case, we should disable the promote button until a CV publish has been successful.



Additional info:
Comment 2 Brad Buckingham 2014-08-04 13:34:52 UTC 
Created redmine issue http://projects.theforeman.org/issues/6913 from this bug
Comment 3 Brad Buckingham 2014-08-04 13:41:32 UTC 
Proposed fix in Katello PR: 
https://github.com/Katello/katello/pull/4523
Comment 6 Tazim Kolhar 2014-08-28 08:19:00 UTC 
Created attachment 931765 [details]
publish failed promote button is disabled

VERIFIED

screenshot attached
Comment 7 Bryan Kearney 2014-09-11 12:22:54 UTC 
This was delivered with Satellite 6.0 which was released on 10 September 2014.