Bug 1092176

Summary:	Review Request: adwaita-icon-theme - Adwaita icon theme
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <kalevlember>
Component:	Package Review	Assignee:	Adam Williamson <awilliam>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	awilliam, package-review
Target Milestone:	---	Flags:	awilliam: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	adwaita-icon-theme-3.13.1-1.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-29 14:35:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2014-04-28 22:07:32 UTC

Spec URL: http://kalev.fedorapeople.org/adwaita-icon-theme.spec
SRPM URL: http://kalev.fedorapeople.org/adwaita-icon-theme-3.13.1-1.fc21.src.rpm
Description:
In upstream, gnome-icon-theme and gnome-icon-theme-symbolic were merged together into a single icon theme, available under the adwaita-icon-theme name.

Fedora Account System Username: kalev

Comment 1 Adam Williamson 2014-04-28 22:43:19 UTC

Accepting for review. All MUST and SHOULD items at https://fedoraproject.org/wiki/Packaging:ReviewGuidelines are 'good' or 'N/A'.

rpmlint output - only warning is:

adwaita-icon-theme-devel.noarch: W: no-documentation

it depends on the main package, so that's fine.

Package built correctly in Koji for Rawhide (scratch build test) with no obvious issues in build.log, contents are as expected.

Package is approved.

(note for those playing along at home: though this is essentially intended to replace gnome-icon-theme{-symbolic}, it's not a transparent replacement, the theme name was actually changed, so it can't simply immediately obsolete/provide those two; dependent packages need to be updated to use the new theme name.)

Comment 2 Kalev Lember 2014-04-28 23:02:31 UTC

Thanks for the review, Adam!

New Package SCM Request
=======================
Package Name: adwaita-icon-theme
Short Description: Adwaita icon theme
Owners: kalev
Branches:
InitialCC:

Comment 3 Gwyn Ciesla 2014-04-29 11:48:36 UTC

Git done (by process-git-requests).

Comment 4 Kalev Lember 2014-04-29 14:35:12 UTC

Package imported and built; closing the ticket.