Bug 1092752

Summary:	Get rid of the fenceSpmStorage calls
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Federico Simoncelli <fsimonce>
Component:	ovirt-engine	Assignee:	Liron Aravot <laravot>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Gal Amado <gamado>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.5.0	CC:	acanan, amureini, gklein, iheim, lpeer, nsoffer, rbalakri, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone:	---
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:	ovirt-3.5.0_rc1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-16 19:10:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1142923, 1156165

Description Federico Simoncelli 2014-04-29 22:08:21 UTC

Description of problem:
The support of fenceSpmStorage on the vdsm side was left only for backward compatibility. It's time to discuss the removal on the engine side as well.

Comment 2 Nir Soffer 2014-04-30 10:30:14 UTC

We must keep this call for older engines, so we gain nothing but uneeded complexity on the engine side by removing the call on the vdsm side.

And we loose the ability to do something useful when this call issue issued in future version.

Comment 3 Federico Simoncelli 2014-04-30 22:09:33 UTC

(In reply to Nir Soffer from comment #2)
> We must keep this call for older engines, so we gain nothing but uneeded
> complexity on the engine side by removing the call on the vdsm side.

That's why this bug is filed on ovirt-engine-backend. This RFE is indeed intended to simplify the engine side, th current fenceSpmStorage is useless and should be removed.

> And we loose the ability to do something useful when this call issue issued
> in future version.

Currently in the fashion that it's used on the engine side and how it's implemented on the vdsm side is useless.
Whenever we'll decide to have this again we'll implement it properly on the vdsm side and we'll call it appropriately from engine side, now it's only pollution.

Comment 6 Gal Amado 2014-08-12 12:40:37 UTC

Verified on :
oVirt Engine Version: 3.5.0-0.0.master.20140804172041.git23b558e.el6
vdsm Version: vdsm-4.16.1-6.gita4a4614.el6.x86_64


The scenario I used to verify it was :
- a system up and running with 2 hosts.
- on the spm host , I've killed vdsms and supervdsd .
- on the GUI , I've clicked "confirm host was rebooted"
- on the engine.log, I saw that "FenceVdsManualyCommand" was triggered, 
  and "fenceSpmStorage" was not .

Comment 7 Allon Mureinik 2015-02-16 19:10:46 UTC

RHEV-M 3.5.0 has been released, closing this bug.