Bug 1092841

Summary:	[barrier] barrier enable/disable returns success even if barrier is already enabled/disabled
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs, gluster-bugs, kaushal, kparthas, nsathyan, sasundar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1100577 (view as bug list)		Environment:
Last Closed:	2014-11-11 08:31:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1100577

Description Atin Mukherjee 2014-04-30 05:35:24 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.gluster v barrier test-vol enable
2.gluster v barrier test-vol enable


Actual results:
volume barrier: command successful

Expected results:
Command should fail as barrier is already enabled


Same steps for barrier disable flow.

Comment 1 Anand Avati 2014-04-30 05:46:58 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if barrier is already enabled/disabled) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2014-05-01 06:58:42 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2014-05-01 12:06:58 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2014-05-02 06:40:01 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2014-05-02 10:19:12 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2014-05-07 05:28:54 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#6) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2014-05-07 10:36:50 UTC

REVIEW: http://review.gluster.org/7609 (glusterd : barrier enable/disable should fail if already enabled/disabled) posted (#7) for review on master by Atin Mukherjee (amukherj)

Comment 8 Anand Avati 2014-05-12 11:37:10 UTC

COMMIT: http://review.gluster.org/7609 committed in master by Kaushal M (kaushal) 
------
commit e64dd0a358e7a7b4c0da86a6b17adf6f125c00d5
Author: Atin Mukherjee <amukherj>
Date:   Wed Apr 30 11:12:40 2014 +0530

    glusterd : barrier enable/disable should fail if already enabled/disabled
    
    In barrier notify function, if we fail to set the barrier option execution goes
    to default_notify which returns 0 and command returns success.
    
    Fix : We need not call the default_notify function when handling
    GF_EVENT_TRANSLATOR_OP in barrier xlator's notify.
    
    Change-Id: Ia2c361b43cca7791c29829d69dcd6fc7923102f6
    BUG: 1092841
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/7609
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Sachin Pandit <spandit>
    Reviewed-by: Kaushal M <kaushal>

Comment 9 Niels de Vos 2014-09-22 12:39:26 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 10 Niels de Vos 2014-11-11 08:31:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users