Bug 1092935

Summary:	Review Request: estonianidcard - Meta-package for Estonian ID-card software
Product:	[Fedora] Fedora	Reporter:	Mihkel Vain <mihkel.vain>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	lkundrak, lrintel, package-review
Target Milestone:	---	Flags:	lkundrak: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-12-10 20:04:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1054941
Bug Blocks:

Description Mihkel Vain 2014-04-30 09:48:53 UTC

Spec URL: http://mihkel.fedorapeople.org/SPECS/estonianidcard.spec
SRPM URL: http://mihkel.fedorapeople.org/SRPMS/estonianidcard-3.8.1-1.fc20.src.rpm
Description: A meta-package to download all required packages to use Estonian ID-card.

Fedora Account System Username: mihkel

Comment 1 Lubomir Rintel 2014-11-10 09:33:01 UTC

> License:        LGPLv2+

Now, what does the License: tag stand for when there's no files in the package... (I don't know)

> Requires:       opensc
> Requires:       pcsc-lite
> Requires:       qdigidoc

Are these three required? Maybe they should be dragged in by the other *esteid* packages?

> %doc

Please drop this, it's of no use.

Comment 2 Mihkel Vain 2014-11-10 10:02:12 UTC

Spec URL: http://mihkel.fedorapeople.org/SPECS/estonianidcard.spec
SRPM URL: http://mihkel.fedorapeople.org/SRPMS/estonianidcard-3.8.1-2.fc20.src.rpm

(In reply to Lubomir Rintel from comment #1)
> > License:        LGPLv2+
> 
> Now, what does the License: tag stand for when there's no files in the
> package... (I don't know)
> 

I added it there, because otherwise rpmlint complains.

> > Requires:       opensc
> > Requires:       pcsc-lite
> > Requires:       qdigidoc
> 
> Are these three required? Maybe they should be dragged in by the other
> *esteid* packages?

opensc and pcsc-lite removed, but I think qdigidoc should be there, because since no other esteid package requires it.

> 
> > %doc
> 
> Please drop this, it's of no use.

Removed

Comment 3 Lubomir Rintel 2014-11-10 10:07:25 UTC

Very fine with me then.

APPROVED

Comment 4 Mihkel Vain 2014-11-10 10:12:25 UTC

Thank you

New Package SCM Request
=======================
Package Name: estonianidcard
Short Description: Meta-package for Estonian ID-card software
Upstream URL: https://installer.id.ee/media/sources/
Owners: mihkel
Branches: f20 f21
InitialCC:

Comment 5 Gwyn Ciesla 2014-11-10 13:14:52 UTC

Git done (by process-git-requests).

Comment 6 Lubomir Rintel 2014-12-10 20:04:07 UTC

Seems like it's built and tagged with f21.