Bug 1093500

1. Have you tried CMake to build it?

Actually, I mean if it's possible to build it as a shared library. 

2. Not the latest version packaged.

Hi Christopher -

1. I have tried it, and no, it doesn't build any non-static libraries. From what I can tell, the project only supports static libraries on non-Windows systems.

2. I noted this in my initial comment. The downstream packages bundle this version of clasp, and they won't build with the newest version. If we want to unbundle the clasp that they use, we'll need to use the version that they use. So until gringo and clingo update to the newest clasp, we'll need to keep this version as-is.

Thanks!

--scott

SPEC:

0. 3.0.6 is available. Notified yet upstream about the wrong license header? I don't think you need to modify them, just let upstream know and fix that.

1. cd build/custom_mt && make %{?_smp_mflags}

make %{?_smp_mflags} -C build/custom_mt

2. install -m0755 -D build/custom_mt/bin/%{name} %{buildroot}%{_bindir}/%{name}
install -m0644 -D build/custom_mt/lib%{name}/lib/lib%{name}.a %{buildroot}%{_libdir}/lib%{name}.a

Missing -p option to preserve the timestamp.

3. Requires:       tbb-devel >= 3.0.0

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Christopher -

Thanks for the feedback.

(1) and (2) have been fixed as described.

For (3), I assume you were looking for the -devel package to depend on the base. I added that.

For (0), I'm sorry to report that this is not a straightforward fix. Current versions of gringo and clingo bundle version 3.0.1 of clasp, and won't build with newer versions of clasp. So in order to un-bundle clasp later, I have to use older clasp here. I've contacted upstream about this issue to see what they have to say about this issue, and the FSF address issue. Until they have a fix, we can't use the newest version.

Thanks,

--scott

Spec URL: http://cottsay.fedorapeople.org/clasp/clasp.spec
SRPM URL: http://cottsay.fedorapeople.org/clasp/clasp-3.0.1-2.fc21.src.rpm

Upstream just released new versions of this chain that are sync'd properly. All packages are now building at their latest versions without any bundled software.

Spec URL: https://cottsay.fedorapeople.org/clasp/clasp.spec
SRPM URL: https://cottsay.fedorapeople.org/clasp/clasp-3.1.0-1.fc20.src.rpm

Copr builds (F20, F21 and rawhide):
http://copr.fedoraproject.org/coprs/cottsay/gringo/monitor/

rpmlint output:
SPECS/clasp.spec:39: W: configure-without-libdir-spec
clasp.x86_64: W: spelling-error Summary(en_US) nogood -> no good, no-good, Gounod
clasp.x86_64: W: spelling-error %description -l en_US nogood -> no good, no-good, Gounod
clasp.x86_64: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability
clasp.x86_64: W: no-manual-page-for-binary clasp
clasp-devel.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 6 warnings.

Thanks,

--scott

There is interest in a downstream package, aspcud, being added in the near future.

Christopher, is there any chance you can take another look at this anytime soon?

Thanks,

--scott

Christopher are you interested in progressing the review of this package?

James - Christopher has been MIA on this review for a very long time now, despite being pinged about it. If you are able, please take the review so we can proceed.

--scott

Okay, I'm going to throw this review back into the pool. Haven't heard from Christopher in over a year.

--scott

Hi,

Are you still interested in this (series of) reviews? I'm happy to take them.

Ping.

aspcud is the recommended external depsolver for opam, the OCaml package manager. I've been taking over work on packaging opam (that got stalled back in 2015), and it would be nice to be able to get aspcud and its dependency stack into Fedora too.

As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews, please respond soon if you're still interested in these reviews.

Yes, I can continue with the review. I'll do my best to get it updated to the latest sources by EOW.

Awesome, thanks a lot.

Let me know when it's ready, and I'll review (and the other packages that depend on it). :)

Hey, Ben -

I did some work on this Sunday, and it looks like the Potassco codebase is in significantly better shape than it was when I started these reviews. Instead of the currently proposed model, I'd like to make these three packages:
1) libpotassco
2) clasp
3) clingo
   - clingo
   - gringo
   - libreify
   - python-clingo
   - lua-clingo

I have the first two done-ish, but the last one is pretty big, and unfortunately I need to do some work to unbundle clasp and libpotassco from it.

I'll keep you updated, and will probably submit the first two for review sooner rather than later. The spec files are structured almost identically, anyway.

Hi Scott,

Is this still something you're working on? I don't think libpotassco ever was submitted for review.

opam 2 supports an internal solver, so these packages are no longer necessary for it. But I'd still be happy to review them if you are interested.

If not, I think we should close these tickets in accordance with the policy for stalled reviews:
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Stalled

I'm not motivated to make this happen anymore - anyone should feel free to pick it up if they're interested.