Bug 1093692

Summary:	Resource/Memory leak issues reported by Coverity.
Product:	[Community] GlusterFS	Reporter:	Lalatendu Mohanty <lmohanty>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	pre-release	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1093698 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:38:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1093698

Description Lalatendu Mohanty 2014-05-02 11:24:47 UTC

Description of problem:

Resource leak issues reported by Coverity.

CID      Type

1124714	Resource leak
1124719	Resource leak
1124723	Resource leak
1124725	Resource leak
1124729	Resource leak
1124730	Resource leak
1124731	Resource leak
1124732	Resource leak
1124734	Resource leak
1124745	Resource leak
1124749	Resource leak
1124759	Resource leak
1124760	Resource leak
1124761	Resource leak
1124768	Resource leak
1124770	Resource leak
1124772	Resource leak
1124773	Resource leak
1124774	Resource leak
1124775	Resource leak
1124776	Resource leak
1124778	Resource leak
1124787	Resource leak
1124788	Resource leak
1124789	Resource leak
1124792	Resource leak
1124795	Resource leak
1128916	Resource leak
1128917	Resource leak
1128918	Resource leak
1128919	Resource leak
1128920	Resource leak
1128921	Resource leak
1128922	Resource leak
1174824	Resource leak
1174825	Resource leak
1174826	Resource leak
1174827	Resource leak
1174828	Resource leak
1175012	Resource leak
1175013	Resource leak
1175014	Resource leak
1175015	Resource leak
1175016	Resource leak
1175017	Resource leak
1175020	Resource leak
1175021	Resource leak
1175022	Resource leak
1192875	Resource leak
1194653	Resource leak
1202394	Resource leak
1202395	Resource leak
1202396	Resource leak
1202397	Resource leak
1202398	Resource leak
1202399	Resource leak
1202400	Resource leak
1202401	Resource leak
1202402	Resource leak
1202403	Resource leak
1202404	Resource leak
1210983	Resource leak
1210984	Resource leak
1210985	Resource leak
1210986	Resource leak
1210987	Resource leak
1210988	Resource leak
1210989	Resource leak


Coverity scan url: https://scan6.coverity.com:8443/reports.htm#v27429/p10714

Guideline for fixing Coverity issues :

http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis#Coverity

This issues are reported by Coverity scan program on master branch of GlusterFS and the head was at "commit b3031351b0e69195413f5f5b9cad2752e3eb713d"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-11-28 07:26:43 UTC

REVIEW: http://review.gluster.org/9208 (glusterd: Coverity fix for string_overflow overrun) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2014-11-30 08:44:13 UTC

REVIEW: http://review.gluster.org/9208 (glusterd: Coverity fix for string_overflow overrun) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2014-12-09 07:10:49 UTC

COMMIT: http://review.gluster.org/9208 committed in master by Kaushal M (kaushal) 
------
commit 4aa63e28509eb47d293eddb4f61317d409598c23
Author: GauravKumarGarg <ggarg>
Date:   Fri Nov 28 12:02:20 2014 +0530

    glusterd: Coverity fix for string_overflow overrun
    
    In function glusterd_dump_peer() it is copying "input_key" into "key"
    buffer without checking the length which might cause string_overflow
    overrun. Similar problem with other coverity issue.
    With this fix it will copy "input_key" into "key" buffer by maximum
    length of buffer.
    
    Coverity CID: 1256171
    Coverity CID: 1256172
    Coverity CID: 1256174
    
    Change-Id: I4e092309d9503bd79ff82cf83ed5e8d758743453
    BUG: 1093692
    Signed-off-by: Gaurav Kumar Garg  ggarg <ggarg>
    Reviewed-on: http://review.gluster.org/9208
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Kaushal M <kaushal>

Comment 4 Anand Avati 2014-12-26 04:44:13 UTC

REVIEW: http://review.gluster.org/9338 (glusterd: coverity fix for overrun in glusterd_stop_uds_listener) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2014-12-26 07:09:44 UTC

REVIEW: http://review.gluster.org/9338 (glusterd: coverity fix for overrun in glusterd_stop_uds_listener) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2014-12-26 07:12:27 UTC

REVIEW: http://review.gluster.org/9338 (glusterd: coverity fix for overrun in glusterd_stop_uds_listener) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2014-12-29 05:25:37 UTC

COMMIT: http://review.gluster.org/9338 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 94dacaa4e91d11760666e9c4e4a6bdf39ae03c6b
Author: Atin Mukherjee <amukherj>
Date:   Fri Dec 26 10:12:11 2014 +0530

    glusterd: coverity fix for overrun in glusterd_stop_uds_listener
    
    CID: 1260432
    
    Change-Id: I6845bc4c231b53428419a5a2ad0c78ea9da31058
    BUG: 1093692
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/9338
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 8 Anand Avati 2015-04-10 19:42:28 UTC

REVIEW: http://review.gluster.org/10201 (glusterd: Coverity fix) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Anand Avati 2015-04-14 05:30:49 UTC

REVIEW: http://review.gluster.org/10201 (glusterd: Coverity fix) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 10 Anand Avati 2015-04-29 07:24:17 UTC

REVIEW: http://review.gluster.org/10201 (glusterd: Coverity fix) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 11 Anand Avati 2015-04-30 13:28:32 UTC

REVIEW: http://review.gluster.org/10201 (glusterd: Coverity fix) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 12 Anand Avati 2015-05-01 18:20:50 UTC

REVIEW: http://review.gluster.org/10201 (glusterd: Coverity fix) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 13 Anand Avati 2015-05-05 10:50:25 UTC

COMMIT: http://review.gluster.org/10201 committed in master by Kaushal M (kaushal) 
------
commit ed9e9c3b1867867a828020b8569c0c7ab1d3be24
Author: Gaurav Kumar Garg <ggarg>
Date:   Sat Apr 11 01:03:13 2015 +0530

    glusterd: Coverity fix
    
    CID: 1293504 (Calling xlator_set_option without checking return value )
    
    CID: 1293502 (Dereferencing a pointer that might be null xl when calling
                  xlator_set_option)
    
    CID: 1293500 (Assigning value from dict_get_int32(dict, "type", &type)
                  to ret here, but that stored value is overwritten before
                  it can be used.)
    
    Change-Id: I5314fb399480df70bd77bc374e3b573f2efd5710
    BUG: 1093692
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10201
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Kaushal M <kaushal>

Comment 14 Anand Avati 2015-05-05 11:53:29 UTC

REVIEW: http://review.gluster.org/10578 (glusterd: Coverity fix) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 15 Niels de Vos 2015-05-14 17:25:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 16 Niels de Vos 2015-05-14 17:35:26 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 17 Niels de Vos 2015-05-14 17:37:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 18 Niels de Vos 2015-05-14 17:42:18 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 19 Niels de Vos 2016-06-16 12:38:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 20 Niels de Vos 2016-06-16 16:17:49 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user