Bug 1093797
| Summary: | Run test suite during build, make build more verbose | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | gtkhtml3 | Assignee: | Matthew Barnes <mbarnes> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | mbarnes, mcrha, ville.skytta | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-05-06 17:32:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ville Skyttä
2014-05-02 17:20:39 UTC
Created attachment 891974 [details]
Run test suite during build
- Make build more verbose
Thanks for a bug report and the patch. Could you be more specific why you want to do these changes, please? It seems to me that verbose rpm build from spec is useless in general, it's good only when the builder is debugging something. Similar to running the test suite, where the tests here are not that much useful in gtkhtml3, from my point of view. As the last, but not the least, gtkhtml3 is basically dead these days, it gets "abandoned" once Evolution switches to webkit-based composer, because the composer itself is the last place which uses GtkHTML in Evolution. Verbose builds are a good way to see if e.g. the expected compiler flags are being used. I don't think there is a good use case for non-verbose build logs for rpm package builds. Non-verbose build logs are good for example for developers who only want to see e.g. warnings, but those builds are something developers should IMO be doing on their own, not for distro rpm packages. This is not only my opinion, I think it's also the consensus between packagers. Regarding test suites, there was a recent discussion on Fedora devel list about them, and in that I interpreted the consensus being that if there is a test suite available in package's sources and it can be sanely run during build, it also should be run during the build. It's possible that there will even be a mass bug filing about this sometime once someone figures out a reliable enough way of automatically finding cases where a test suite which is not run during build exists. Some GNOME projects adapted to the NicerBuilds goal early [1]. It got lost meanwhile, or basically not approved, I do not recall, but my point is that there are more projects "affected". It doesn't work for everyone, yes, and I'm not much happy of it personally too, but I'm also not strictly against it. That said, as a current co-maintainer of gtkhtml3, I'm not going to disable silent rules for it as of now. Once there will be a requirement to enable this fedora-wide, I can do it. I just think that the change doesn't bring anything special right now. [1] https://wiki.gnome.org/Initiatives/GnomeGoals/NicerBuilds |