Bug 1094061

Summary: [RFE] Thin pool should support offline metadata resize
Product: [Fedora] Fedora Reporter: Zdenek Kabelac <zkabelac>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: agk, bmarzins, bmr, dwysocha, heinzm, jonathan, lvm-team, mbukatov, msnitzer, prajnoha, zkabelac
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1104702 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1104702    

Description Zdenek Kabelac 2014-05-04 20:59:10 UTC
Description of problem:

Resize of thin pool's metada is supported only when thin pool is online.
Add support for metadata resize of inactive pool.

This may require multiple steps together with execution of thin util.

Version-Release number of selected component (if applicable):
2.02.106

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Zdenek Kabelac 2014-05-13 12:15:29 UTC
Thinking about the issue - we most likely will need to update metadata to add temporary backup metadata into pool metadata structure (and probably using sendfile() to copy data - since we may at most copy ~16GB which should be rather quick operation)

Then we resize the original metadata volume - and run  thin_repair to recreate 'backup' metadata into the original metadata space. And finally free 'backup' metadata as the last step (in case the new resized metadata would be wrong - there is always chance to 'swap' back the old ones in recovery path...)

This method seems to have the advantage we preserve policy and allocation position of original pool's metadata and in every step we have always unmodified metadata available.

While 'backup' metadata are attached - we do not allow activation of thin pool. To recover/repair activation   'backup' needs to be removed (lvconvert --repair).