Bug 1094196

Summary: [engine-backend] [iSCSI multipath] It's possible to remove a network from the setup even though it participates in an iSCSI multipath bond
Product: Red Hat Enterprise Virtualization Manager Reporter: Elad <ebenahar>
Component: ovirt-engineAssignee: Maor <mlipchuk>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: amureini, gklein, iheim, lpeer, rbalakri, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone: ---Keywords: ZStream
Target Release: 3.5.0Flags: amureini: Triaged+
Hardware: x86_64   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.5.0_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1126221 (view as bug list) Environment:
Last Closed: 2015-02-16 19:10:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1126221, 1142923, 1156165    
Attachments:
Description Flags
Logs from engine and host none

Description Elad 2014-05-05 09:36:55 UTC
Created attachment 892483 [details]
Logs from engine and host

Description of problem:
Remove networks from RHEVM isn't blocked while the network is attached to an iSCSI bond

Version-Release number of selected component (if applicable):
AV7
rhevm-3.4.0-0.15.beta3.el6ev.noarch

How reproducible:
Always

Steps to Reproduce:
On a shared DC with 1 active iSCSI storage domain:
1. Create 2 new networks and attach them to the cluster without required check-box checked
2. Attach the networks to the cluster's hosts NICs 
3. Create a new iSCSI multipath bond (under DC tab -> pick the relevant DC -> iSCSI multipath sub-tab -> new) and add the new networks along with the targets to it
4. After the bond is set, try to remove one of the network that participate in the iSCSI multipath bond from RHEVM (via 'Network' main-tab) (be sure not to remove the MGMT-rhevm/ovirtmgmt network).


Actual results:
Even though the network is attached to the iSCSI bond, it's possible to remove it from the setup:

2014-05-05 12:22:49,657 INFO  [org.ovirt.engine.core.bll.network.dc.RemoveNetworkCommand] (org.ovirt.thread.pool-4-thread-10) [5ff5a3a9] Running command: RemoveNetworkCommand internal: false. Entities affected :  ID: 789c0a01-a8a6-4f45-bd49-8c2b1c03e711 Type: Network
2014-05-05 12:22:49,676 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.pool-4-thread-10) [5ff5a3a9] Correlation ID: 5ff5a3a9, Call Stack: null, Custom Event ID: -1, Message: Network iscsi3 was removed from Data Center: dc1



Expected results:
Removing a network from RHEVM should be blocked if the network participate in an iSCSI bond

Additional info: Logs from engine and host

Comment 3 Elad 2014-08-10 14:42:37 UTC
Attempt to remove a network that participates in an iSCSI multipath bond is now blocked with a CDA message:

2014-08-10 17:40:51,355 WARN  [org.ovirt.engine.core.bll.network.dc.RemoveNetworkCommand] (ajp--127.0.0.1-8702-10) [1e0baa10] CanDoAction of action RemoveNetwork failed. Reasons:VAR__TYPE__NETWORK,VAR__ACTION__REMOVE,NETWORK_CANNOT_REMOVE_ISCSI_BOND_NETWORK,$IscsiBonds   1,$IscsiBonds_COUNTER 1,$NetworkName s1


Check with ovirt-3.5 RC1

Comment 4 Allon Mureinik 2015-02-16 19:10:07 UTC
RHEV-M 3.5.0 has been released, closing this bug.