Bug 1094214

Summary:	Review Request: rubygem-pdf-core - PDF::Core is used by Prawn to render PDF documents
Product:	[Fedora] Fedora	Reporter:	Josef Stribny <jstribny>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, package-review, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-pdf-core-0.2.5-1.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-23 13:02:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Josef Stribny 2014-05-05 10:14:28 UTC

Spec URL: http://data-strzibny.rhcloud.com/rubygem-pdf-core.spec
SRPM URL: http://data-strzibny.rhcloud.com/rubygem-pdf-core-0.2.5-1.fc21.src.rpm
Description: PDF::Core is used by Prawn to render PDF documents
Fedora Account System Username: jstribny

This package is needed to package final 1.0.0 version of Prawn.

You would need an updated version of rubygem-pdf-inspector to build/test it[1]. I haven't updated it yet, because it would break current rc2 version of Prawn. I will do the update when the package is approved and then update Prawn as well.


[1] http://data-strzibny.rhcloud.com/rubygem-pdf-inspector-1.1.0-1.fc21.noarch.rpm

Comment 1 Vít Ondruch 2014-06-18 12:31:56 UTC

I'll take this for a review.

Comment 2 Vít Ondruch 2014-06-18 12:47:03 UTC

* rpmlint output:
  - rubygem-pdf-core.noarch: E: useless-provides rubygem(pdf-core)

    This provide is now autogenerated and can be removed from spec file.

  - rubygem-pdf-core.noarch: E: incorrect-fsf-address
      /usr/share/gems/gems/pdf-core-0.2.5/GPLv2

    You should ask upstream to fix the address.

* Confusing Patch0 comment
  - Seems that the patch relaxes dependency on pdf-reader, not on pdf-core.
  - Why is the dependency so tight? Or why not make it explicit, if you override
    the defaults anyway?

Otherwise, the package looks sane => APPROVED

Comment 3 Josef Stribny 2014-06-19 12:42:27 UTC

Thank you, I will fix the issues you have found before building.

New Package SCM Request
=======================
Package Name: rubygem-pdf-core
Short Description: PDF::Core is used by Prawn to render PDF documents
Upstream URL: http://prawn.majesticseacreature.com
Owners: jstribny
Branches: 
InitialCC:

Comment 4 Kevin Fenzi 2014-06-19 20:53:42 UTC

Git done (by process-git-requests).