Bug 1094226

Summary: Changelog: Add timeout in changelog barrier.
Product: [Community] GlusterFS Reporter: Kotresh HR <khiremat>
Component: geo-replicationAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: pre-releaseCC: bugs, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1105444 (view as bug list) Environment:
Last Closed: 2014-11-11 08:31:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1105444    

Description Kotresh HR 2014-05-05 10:29:45 UTC
Description of problem:

If for some reason after barrier 'on' notification from glusterfsd mgmt
during snapshot, corresponding barrier 'off' notification does not come
to changelog, the changelog barrierd fops will be barriered indefinitely.

 

Expected results:
A configurable timeout should be avialable, on timeout of which, all barriered
fops should be unbarriered. If barrier 'off' notification from glusterfsd mgmt
comes after timeout, return -1 so that the snapshot taken is failed.

Additional info:

Comment 1 Anand Avati 2014-05-05 10:47:35 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 2 Anand Avati 2014-05-06 05:19:52 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2014-05-06 06:47:03 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 4 Anand Avati 2014-05-15 05:01:23 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 5 Anand Avati 2014-05-21 09:15:53 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#5) for review on master by Kotresh HR (khiremat)

Comment 6 Anand Avati 2014-05-23 07:23:52 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#6) for review on master by Kotresh HR (khiremat)

Comment 7 Anand Avati 2014-05-26 12:17:19 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#7) for review on master by Kotresh HR (khiremat)

Comment 8 Anand Avati 2014-06-10 06:44:21 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#8) for review on master by Kotresh HR (khiremat)

Comment 9 Anand Avati 2014-06-10 09:01:51 UTC
REVIEW: http://review.gluster.org/7669 (feature/changelog: Add timeout to changelog barrier.) posted (#9) for review on master by Kotresh HR (khiremat)

Comment 10 Anand Avati 2014-06-10 10:36:07 UTC
COMMIT: http://review.gluster.org/7669 committed in master by Venky Shankar (vshankar) 
------
commit b97e8f4ef649ed825b4f02b74e33946f6b551cec
Author: Kotresh H R <khiremat>
Date:   Mon May 5 15:33:25 2014 +0530

    feature/changelog: Add timeout to changelog barrier.
    
    This patch introduces configurable 'changelog-barrier-timeout'
    in changelog. The default changelog-barrier-timeout is set to
    120 sec which is same as barrier-timeout of barrier translator.
    On this timeout, all the barriered fops are unbarriered. It is
    safe to have this internal timeout for changelog barrier to
    prevent it from indefinite barrierring of fops if barrier
    disable notification does not come from snapshot for some
    reason.
    
    Change-Id: Iad07807935f88222cdefcd46312b4b6579186dce
    BUG: 1094226
    Signed-off-by: Kotresh H R <khiremat>
    Reviewed-on: http://review.gluster.org/7669
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 11 Niels de Vos 2014-09-22 12:39:33 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 12 Niels de Vos 2014-11-11 08:31:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users