Bug 1094325 (kf5-kconfig)
| Summary: | Review Request: kf5-kconfig - KDE Frameworks 5 Tier 1 addon with advanced configuration system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-21 12:39:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148 | ||
|
Description
Daniel Vrátil
2014-05-05 13:09:52 UTC
Doesn't build, because it cannot find /usr/libexec/kf5/kconf_update, because this file is installed to /usr/lib64/libexec/kf5/kconf_update. Sorry, I forgot to update kf5-rpm-macros in rawhide. Please try again against kf5-rpm-macros-4.99.0-3 (should be available in rawhide now, or from our Copr) 1) License should be GPLv2+ and LGPLv2+ and MIT/X11 2) Too long description 3) Missing ldconfig call in postin/postun for subpackages 4) kf5-kconfig should be noarch - http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig-4.99.0-2.fc20.src.rpm Fixed 1, 2 and 3. Ad 4): kf5-kconfig requires kf5-kconfig-core%{?_isa}, so there's difference between installing kf5-kconfig.i686 and kf5-kconfig.x86_64 which is right IMO. If kf5-kconfig would be noarch, then you wouldn't be able to use it to install all subpackages for non-native arch. Also it seems that if you make base package noarch, then all subpackages must be noarch, which is not the case here howerver, so this cannot be implemented. 1) MIT/X11 should be just MIT, sorry my mistake 2) rpmlint is still complaining about too long line in description for base package 3) ok 4) you are probably right, I didn't realize that kf5-kconfig is something like metapackage. Issues above can be fixed during import, approved. New Package SCM Request ======================= Package Name: kf5-kconfig Short Description: KDE Frameworks 5 Tier 1 addon with advanced configuration system Upstream URL: http://www.kde.org Owners: dvratil rdieter kkofler ltinkl jgrulich Branches: InitialCC: Git done (by process-git-requests). Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Package Change Request ======================= Package Name: kf5-kconfig New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Git done (by process-git-requests). |