Bug 1094478

Summary:	Bad macro in changelog-misc.h
Product:	[Community] GlusterFS	Reporter:	Keith Schincke <kschinck>
Component:	core	Assignee:	Keith Schincke <kschinck>
Status:	CLOSED EOL	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.5.0	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-17 16:24:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Keith Schincke 2014-05-05 19:15:54 UTC

Description of problem:
the CHANGELOG_GET_ENCODING macro uses the elen variable within the do/while statement. This is a value outside of the macro (xlators/features/changelog/lib/gf_changelog_process.c:gf_changelog_decode() ).
The macro should use the enc_len macro agtument. 

As written, this macro can only be used in functions where elen is in scope. 

Version-Release number of selected component (if applicable):
3.5

How reproducible:
All

Steps to Reproduce:
1. Review line 55 of https://github.com/gluster/glusterfs/blame/master/xlators/features/changelog/src/changelog-misc.h#L55
2.
3.

Actual results:
elen = strlen (buffer) ;

Expected results:
enc_len = strlen (buffer) ;

Additional info:

Comment 1 Anand Avati 2014-06-19 06:20:14 UTC

REVIEW: http://review.gluster.org/8110 (Bad macros CHANGELOG_GET_ENCODING bug 1094478) posted (#1) for review on master by Keith Schincke (kschinck)

Comment 2 Mike McCune 2016-03-28 22:53:35 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 3 Niels de Vos 2016-06-17 16:24:04 UTC

This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.