Bug 1094539

Summary:	createrepo_c doesnt clean up after itself correctly
Product:	[Fedora] Fedora EPEL	Reporter:	Dennis Gilmore <dennis>
Component:	createrepo_c	Assignee:	Tomas Mlcoch <tmlcoch>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	jzeleny, tmlcoch
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	createrepo_c-0.4.0-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-24 17:59:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dennis Gilmore 2014-05-05 23:41:57 UTC

Description of problem:
createrepo_c leaves old copies of comps files around in the repo

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=2299463 is an example of a case where there should only be one compose file but is heaps

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Fedora Update System 2014-05-06 13:43:48 UTC

createrepo_c-0.4.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/createrepo_c-0.4.0-1.el6

Comment 2 Tomas Mlcoch 2014-05-06 13:44:14 UTC

Hi Dennis,
this behavior was kept because of compatibility with the original createrepo.

I agree that this behavior is bad and I've just built a new version of createrepo_c that introduces a new behavior.

The createrepo_c version that introduces the change is 0.4.0:
* Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6818386
* EPEL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=6818436
* f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6818469

The description of what was changed and example of the old and the new behavior can be found at:
https://github.com/Tojaj/createrepo_c/wiki/New-File-Handling#example

Comment 3 Fedora Update System 2014-05-06 17:32:27 UTC

Package createrepo_c-0.4.0-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing createrepo_c-0.4.0-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-1342/createrepo_c-0.4.0-1.el6
then log in and leave karma (feedback).

Comment 4 Dennis Gilmore 2014-05-06 19:47:56 UTC

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=2302700 it is not fixed

Comment 5 Tomas Mlcoch 2014-05-09 10:48:42 UTC

This new version removes only metadata that were in repomd.xml before the update and are not in it after the update.
Other files that lies in the repodata/ and are not referenced by the repomd.xml are kept untouched - So the files which are already accumulated stay there, but their number should not grow since the new version.

I plan to add a new option which removes all files in repodata/ older than a specified number of days. I will let you know, when this option will be implemented.

Comment 6 Fedora Update System 2014-05-24 17:59:53 UTC

createrepo_c-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.